Merge lp://staging/~doanac/ubuntu-ci-services-itself/binarypackage-fix-1291078 into lp://staging/ubuntu-ci-services-itself

Proposed by Andy Doan
Status: Merged
Approved by: Vincent Ladeuil
Approved revision: 376
Merged at revision: 376
Proposed branch: lp://staging/~doanac/ubuntu-ci-services-itself/binarypackage-fix-1291078
Merge into: lp://staging/ubuntu-ci-services-itself
Diff against target: 68 lines (+11/-10)
3 files modified
lander/bin/ticket_api.py (+1/-1)
ticket_system/ticket/api.py (+4/-3)
ticket_system/ticket/tests/test_write_api.py (+6/-6)
To merge this branch: bzr merge lp://staging/~doanac/ubuntu-ci-services-itself/binarypackage-fix-1291078
Reviewer Review Type Date Requested Status
Vincent Ladeuil (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+210736@code.staging.launchpad.net

Commit message

ticket-system/lander: fix binarypackage api

there was a bug on each side of this api:

lander: had a typo in the ticket_api.py

ticket_sytem: the states are integers, but it was requiring them
to be strings.

Description of the change

fixes the bug where we didn't have a binarypackage list in the ticket system

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:376
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/399/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/399/rebuild

review: Approve (continuous-integration)
Revision history for this message
Vincent Ladeuil (vila) wrote :

Tests that succeed for the wrong reason kill kittens ;)

Nice catch !

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches