Merge lp://staging/~doanac/qa-dashboard/smoke-kpi-fix into lp://staging/qa-dashboard
Proposed by
Andy Doan
| Status: | Merged |
|---|---|
| Approved by: | Chris Johnston |
| Approved revision: | 717 |
| Merged at revision: | 720 |
| Proposed branch: | lp://staging/~doanac/qa-dashboard/smoke-kpi-fix |
| Merge into: | lp://staging/qa-dashboard |
| Diff against target: |
66 lines (+8/-10) 3 files modified
smokeng/dashboard.py (+1/-1) smokeng/management/commands/jenkins_pull_smokeng.py (+0/-9) smokeng/models.py (+7/-0) |
| To merge this branch: | bzr merge lp://staging/~doanac/qa-dashboard/smoke-kpi-fix |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Chris Johnston | Approve | ||
| PS Jenkins bot | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
smoke kpi: fix calculation
now that we have results that can be "running" and "syncing" we need to
update what we query for. Additionally I noticed that "pass_rate" wasn't
being set for results that were "syncing". I could have fixed this from
api.py, but it seemed better to do this in a single place and then
simplify our pull-script logic.
Description of the change
smoke kpi: fix calculation
now that we have results that can be "running" and "syncing" we need to
update what we query for. Additionally I noticed that "pass_rate" wasn't
being set for results that were "syncing". I could have fixed this from
api.py, but it seemed better to do this in a single place and then
simplify our pull-script logic.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| Chris Johnston (cjohnston) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
PASSED: Continuous integration, rev:717
http://
Executed test runs:
Click here to trigger a rebuild:
http://