Merge lp://staging/~doanac/qa-dashboard/smoke-image-unique into lp://staging/qa-dashboard
Proposed by
Andy Doan
Status: | Merged |
---|---|
Approved by: | Andy Doan |
Approved revision: | 742 |
Merged at revision: | 742 |
Proposed branch: | lp://staging/~doanac/qa-dashboard/smoke-image-unique |
Merge into: | lp://staging/qa-dashboard |
Diff against target: |
64 lines (+28/-1) 2 files modified
smokeng/models.py (+14/-1) smokeng/tests.py (+14/-0) |
To merge this branch: | bzr merge lp://staging/~doanac/qa-dashboard/smoke-image-unique |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Joe Talbott | Approve | ||
PS Jenkins bot | continuous-integration | Approve | |
Paul Larson | Approve | ||
Review via email: mp+218336@code.staging.launchpad.net |
Commit message
dashboard api: remove race condition
The dashboard itself is changing to prevent the creation of duplicate
SmokeImage objects. We'll now get this as an http exception when trying
to create an object. We need to handle that by then doing a GET call
to find the SmokeImage created by the other thread that won the race.
Description of the change
This is the backend change needed by:
https:/
See commit-message for dirty details
To post a comment you must log in.
PASSED: Continuous integration, rev:741 s-jenkins. ubuntu- ci:8080/ job/dashboard- ci/324/
http://
Executed test runs:
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/dashboard- ci/324/ rebuild
http://