Code review comment for lp://staging/~doanac/lava-scheduler/5-longest-jobs

I think you should consider the case when there are no running jobs --
it does happen! -- and just display "no jobs running" or something in
that situation.

Cheers,
mwh

Andy Doan <email address hidden> writes:

> Andy Doan has proposed merging lp:~doanac/lava-scheduler/5-longest-jobs into lp:lava-scheduler.
>
> Requested reviews:
> Linaro Validation Team (linaro-validation)
>
> For more details, see:
> https://code.launchpad.net/~doanac/lava-scheduler/5-longest-jobs/+merge/115422
>
> simple report to show 5 longest running jobs
> --
> https://code.launchpad.net/~doanac/lava-scheduler/5-longest-jobs/+merge/115422
> You are subscribed to branch lp:lava-scheduler.
> === modified file 'lava_scheduler_app/templates/lava_scheduler_app/reports.html'
> --- lava_scheduler_app/templates/lava_scheduler_app/reports.html 2012-06-16 03:48:18 +0000
> +++ lava_scheduler_app/templates/lava_scheduler_app/reports.html 2012-07-17 19:18:25 +0000
> @@ -142,4 +142,11 @@
> </script>
> </div>
>
> +<h2>Longest Running Jobs</h2>
> +<ul>
> +{% for job in long_running %}
> + <li><a href="{{job.get_absolute_url}}">{{job.id}}</a>: {{job.start_time}}</li>
> +{% endfor %}
> +</ul>
> +
> {% endblock %}
>
> === modified file 'lava_scheduler_app/views.py'
> --- lava_scheduler_app/views.py 2012-06-26 01:49:31 +0000
> +++ lava_scheduler_app/views.py 2012-07-17 19:18:25 +0000
> @@ -232,6 +232,11 @@
> for week in reversed(range(10)):
> health_week_report.append(job_report(week*-7-7, week*-7, True))
> job_week_report.append(job_report(week*-7-7, week*-7, False))
> +
> + long_running = TestJob.objects.filter(
> + status__in = [TestJob.RUNNING, TestJob.CANCELING]
> + ).order_by('start_time')[:5]
> +
> return render_to_response(
> "lava_scheduler_app/reports.html",
> {
> @@ -239,6 +244,7 @@
> 'health_day_report': health_day_report,
> 'job_week_report': job_week_report,
> 'job_day_report': job_day_report,
> + 'long_running': long_running,
> 'bread_crumb_trail': BreadCrumbTrail.leading_to(index),
> },
> RequestContext(request))