LAVA Android Test

Merge lp://staging/~doanac/lava-android-test/install-option-attribute into lp://staging/lava-android-test

  1. install-option-attribute
  2. Merge into trunk
Proposed by Andy Doan
Status: Merged
Merged at revision: 127
Proposed branch: lp://staging/~doanac/lava-android-test/install-option-attribute
Merge into: lp://staging/lava-android-test
Diff against target: 35 lines (+11/-0)
1 file modified
lava_android_test/testdef.py (+11/-0)
To merge this branch: bzr merge lp://staging/~doanac/lava-android-test/install-option-attribute
Reviewer Review Type Date Requested Status
Michael Hudson-Doyle (community) Approve
Review via email: mp+87293@code.staging.launchpad.net

Description of the change

This change builds off the parameterization work to allow the bundle streams to include the install_option value for a test in its "attributes" section.

Michael - I picked you since you did the original grunt work. Let me know if this seems resonable.

To post a comment you must log in.
Revision history for this message
Andy Doan (doanac) wrote :

I just realized I proposed the merge that include revisions 125 and 126. I had done a separate merge request for that:

  https://code.launchpad.net/~doanac/lava-android-test/multiple-result-ids/+merge/87182

Hopefully this doesn't cause any confusion.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Looks nearly OK, except:

        self.adb.shell('echo "%s" > %s/install_options' %
                        (install_options, installdir))

You probably don't want to do this if install_options is None do you? Tweak that and it looks good to me.

review: Approve
lp://staging/~doanac/lava-android-test/install-option-attribute updated
128. By Andy Doan

don't create "install_options" file if none provided

Revision history for this message
Andy Doan (doanac) wrote :

Created a new patch. I think it addresses the issue you noted.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches