Juju Charms Collection
contrail-configuration package

Code review comment for lp://staging/~dmitriis/charms/trusty/contrail-configuration/trunk

  1. Trusty Tahr (14.04)
  2. trunk
  3. Merge into trunk
Revision history for this message
Dmitrii Shcherbakov (dmitriis) wrote :

Robert,

They were separated into two revisions intentionally and it is possible to view the individual diffs.

https://bazaar.launchpad.net/~dmitriis/charms/trusty/contrail-configuration/trunk/revision/66

https://bazaar.launchpad.net/~dmitriis/charms/trusty/contrail-configuration/trunk/revision/67

Lint checks are a normal part of the charm dev process so I think it is worthwhile that they pass:

https://docs.openstack.org/developer/charm-guide/testing.html#lint
https://jujucharms.com/docs/2.1/authors-charm-best-practice#charm-coding-guidelines

« Back to merge proposal