Do

Merge lp://staging/~djsiegel-deactivatedaccount/do/trunk into lp://staging/do/0.8

Proposed by David Siegel
Status: Merged
Merged at revision: not available
Proposed branch: lp://staging/~djsiegel-deactivatedaccount/do/trunk
Merge into: lp://staging/do/0.8
To merge this branch: bzr merge lp://staging/~djsiegel-deactivatedaccount/do/trunk
Reviewer Review Type Date Requested Status
Jason Smith (community) Approve
Review via email: mp+2945@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
David Siegel (djsiegel-deactivatedaccount) wrote :

This branch fixes a lot of the little implicit text item quirks. I've localized the addition of the ImplicitTextItem to search results in UniverseManager.Search. I've also overridden PassesTypeFilter in ProxyElement so SelectTextItem appears as an ITextItem in the second pane again. All of this code will be rewritten for 0.9.

This branch also seeks to address the issues we've had with SelectedTextItem by introducing Services.Application.Summoned to allow plugins to receive a main-thread notification when summon occurs. SelectedTextItems uses this event to read the clipboard at a safe time. However, it's not all that simple -- sometimes we still seem to lock up, even on the main thread.

Please test this branch extensively. Use modifier items, use actions that return results, etc.

Revision history for this message
David Siegel (djsiegel-deactivatedaccount) wrote :

I meant to say, we still seem to lock up in a way we cannot explain, but I've coded around it see r866 for the difference between lock up and smooth sailing. Maybe you guys will figure it out.

863. By David Siegel <david@x>

Focus plugin filter by default.

864. By David Siegel <david@x>

Bug 318131.

Revision history for this message
Jason Smith (jassmith) wrote :

+1

review: Approve
865. By David Siegel <david@x>

Merge implicit text item fixes, and proxy item fix.

Subscribers

People subscribed via source and target branches