txAWS

Merge lp://staging/~djfroofy/txaws/86392-s3copyobj into lp://staging/txaws

  1. 86392-s3copyobj
  2. Merge into trunk
Proposed by Drew Smathers
Status: Merged
Merged at revision: 74
Proposed branch: lp://staging/~djfroofy/txaws/86392-s3copyobj
Merge into: lp://staging/txaws
Diff against target: 160 lines (+65/-9)
2 files modified
txaws/s3/client.py (+26/-4)
txaws/s3/tests/test_client.py (+39/-5)
To merge this branch: bzr merge lp://staging/~djfroofy/txaws/86392-s3copyobj
Reviewer Review Type Date Requested Status
Jamu Kakar Approve
Review via email: mp+35882@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Drew Smathers (djfroofy) wrote :

This depends on branch ~djfroofy/txaws/640098-amazon-headers

Revision history for this message
Jamu Kakar (jkakar) wrote :

I made some minor cosmetic changes to fix PEP-8 warnings, added
missing @param and @return bits to S3Client.copy_object in addition to
adding some missing docstrings.

Sorry for taking so long to review and merge it. Nice work, +1!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches