Merge lp://staging/~djaler1/screenshot-tool/non-interactive-mode into lp://staging/~elementary-apps/screenshot-tool/trunk

Proposed by Kirill Romanov
Status: Merged
Approved by: Fabio Zaramella
Approved revision: 303
Merged at revision: 307
Proposed branch: lp://staging/~djaler1/screenshot-tool/non-interactive-mode
Merge into: lp://staging/~elementary-apps/screenshot-tool/trunk
Diff against target: 254 lines (+95/-57)
2 files modified
src/Screenshot.vala (+4/-2)
src/ScreenshotWindow.vala (+91/-55)
To merge this branch: bzr merge lp://staging/~djaler1/screenshot-tool/non-interactive-mode
Reviewer Review Type Date Requested Status
Fabio Zaramella (community) Approve
Review via email: mp+317674@code.staging.launchpad.net

Commit message

Implement non-interactive mode (fix bug 1665708)

Description of the change

Implement non-interactive mode (fix bug 1665708)

To post a comment you must log in.
Revision history for this message
Fabio Zaramella (fabiozaramella) wrote :

I'm experiencing two problems:
First, sometimes screenshots are saved, sometimes not, but i can't tell when file is correctly saved.
Second, ok it doesn't build up the gui but... app icon still popup in plank and then immediately close, this is really annoying in my opinion and with the problem above you still can't understand when screenshot is correctly saved.

review: Needs Fixing
Revision history for this message
Fabio Zaramella (fabiozaramella) wrote :

Furthermore, when they are saved is in the home folder not in Pictures even though this is the selected folder.

Revision history for this message
Fabio Zaramella (fabiozaramella) wrote :

Oh, and choosing "current window" option sometimes results in icon being kept in plank until i click on it and then close the main program.

Apart from the fact that i can't tell whether they are saved or not and the problem with the folder, when it works, it works good.

Revision history for this message
Kirill Romanov (djaler1) wrote :

@fabiozaramella I made some changes, can you test again?

Revision history for this message
Fabio Zaramella (fabiozaramella) wrote :

@djaler1 I tested it again and i can confirm that icon doesn't blink anymore, but it persists in plank (and i didn't choose to keep it in the dock). Mh, i think icon shouldn't be displayed at all, you can see how gnome-screenshot works for example.
Furthermore, screenshots aren't saved in the correct folder.

Revision history for this message
Kirill Romanov (djaler1) wrote :

It's strange, cause I didn't see icon in plank now.
And about folder - it save into folder that set in net.launchpad.screenshot.folder-dir. You can change it by gsettings, or, for example, by manual save screenshot to correct folder from GUI version of screenshot-tool

Revision history for this message
Fabio Zaramella (fabiozaramella) wrote :

@djaler1 What i mean is that icon persist, for a while, and then disappears. As if main process is not terminated. Can you reproduce it? If not maybe is better to ask someone else to test it.

About folder, you're right, i looked at the string with dconf-editor and it's empty. That's the reason why they are saved in Pictures from the gui version and in the home folder otherwise.
For some reason the gui version doesn't save the string to the schema (i also tried with trunk) so this is a separate problem, maybe it also need to be set to Picture by default, but again this is a separate bug.

Revision history for this message
Kirill Romanov (djaler1) wrote :

https://youtu.be/31muJSAlxqY there are screencast. I doesn't see icon in plank

Revision history for this message
Fabio Zaramella (fabiozaramella) wrote :

Ok, i figured it out:
When screenshots are taken from terminal, as in you screencast, icon doesn't show but screenshot arent' save (not even in the home folder).
When taken from context menu in slingshot the icon pops up and persists for a while and screenshots are saved in the home folder.

Revision history for this message
Kirill Romanov (djaler1) wrote :

I think this is Slingshot or Plank problem. They waiting for application window opening, but it doesn't show.

Revision history for this message
Kirill Romanov (djaler1) wrote :

And there no differnce in taken from context menu or from terminal to saving file. Context menu just execute command.

Revision history for this message
Fabio Zaramella (fabiozaramella) wrote :

Yes, maybe is plank fault, I just thought it would be nice to avoid this, just like gnome does. :) It wasn't a problem before since save dialog was shown.
And, yes i know slingshot just execute the command, that's the reason why it's strange. If i actually tipe the command in terminal the result is that of your screencast, but launching it from slingshot produces a different result.

Revision history for this message
Kirill Romanov (djaler1) wrote :

I think it impossible with currect codebase. May be it's something in Granite.Application. I tried, but even if I don't create ScreenshotWindow icon pops up.

Revision history for this message
Kirill Romanov (djaler1) wrote :

Just for note - with old version of Slingshot (like from September) icon doesn't pops up.

Revision history for this message
Kirill Romanov (djaler1) wrote :

@fabiozaramella so what?

Revision history for this message
Fabio Zaramella (fabiozaramella) wrote :

Ok after some tests i found out that this is a problem in slingshot. Icon doesn't pop up when the program is launched from terminal and the same happens when writing the command in slingshot's search field, it only occurs when choosing the option from context menu.

Sorry for the late reply, approved. :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches