Merge lp://staging/~divmod-dev/divmod.org/nevow-json into lp://staging/divmod.org
Proposed by
Jean-Paul Calderone
| Status: | Merged |
|---|---|
| Approved by: | Tristan Seligmann |
| Approved revision: | 2676 |
| Merged at revision: | 2676 |
| Proposed branch: | lp://staging/~divmod-dev/divmod.org/nevow-json |
| Merge into: | lp://staging/divmod.org |
| Diff against target: |
51 lines (+23/-0) 2 files modified
Nevow/nevow/json.py (+5/-0) Nevow/nevow/test/test_json.py (+18/-0) |
| To merge this branch: | bzr merge lp://staging/~divmod-dev/divmod.org/nevow-json |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Tristan Seligmann | Approve | ||
|
Review via email:
|
|||
Description of the change
I added U+2028 and U+2029 to nevow.json.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good! (I would say "Please merge", but I'm about to set the merge proposal to Approved, which I expect means the same thing)
One thing does occur to me: if you have a reference handy documenting the characters that need to be escaped, it might be useful leaving it in a comment near this code for anyone trying to make sense of it later on.