Merge lp://staging/~dimitern/juju-core/138-api-remove-deprecated-1.14 into lp://staging/~go-bot/juju-core/trunk

Proposed by Dimiter Naydenov
Status: Work in progress
Proposed branch: lp://staging/~dimitern/juju-core/138-api-remove-deprecated-1.14
Merge into: lp://staging/~go-bot/juju-core/trunk
Prerequisite: lp://staging/~dimitern/juju-core/137-fix-state-imports
Diff against target: 474 lines (+40/-300)
9 files modified
state/api/params/internal.go (+0/-33)
state/apiserver/common/setstatus.go (+0/-5)
state/apiserver/common/setstatus_test.go (+0/-18)
state/apiserver/machine/agent.go (+0/-77)
state/apiserver/machine/agent_test.go (+0/-99)
state/apiserver/machine/common_test.go (+0/-45)
state/apiserver/machiner/machiner.go (+1/-1)
state/apiserver/machiner/machiner_test.go (+36/-8)
state/apiserver/root.go (+3/-14)
To merge this branch: bzr merge lp://staging/~dimitern/juju-core/138-api-remove-deprecated-1.14
Reviewer Review Type Date Requested Status
Juju Engineering Pending
Review via email: mp+185531@code.staging.launchpad.net

Description of the change

api: Removed DEPRECATED(v1.14) code

Removed params types marked as deprecated in 1.14,
and also renamed apiserver/machine/ to the more
consistent apiserver/machiner/, like the other
facades.

https://codereview.appspot.com/13700043/

To post a comment you must log in.
Revision history for this message
Dimiter Naydenov (dimitern) wrote :

Reviewers: mp+185531_code.launchpad.net,

Message:
Please take a look.

Description:
api: Removed DEPRECATED(v1.14) code

Removed params types marked as deprecated in 1.14,
and also renamed apiserver/machine/ to the more
consistent apiserver/machiner/, like the other
facades.

https://code.launchpad.net/~dimitern/juju-core/138-api-remove-deprecated-1.14/+merge/185531

Requires:
https://code.launchpad.net/~dimitern/juju-core/137-fix-state-imports/+merge/185519

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/13700043/

Affected files (+42, -300 lines):
   A [revision details]
   M state/api/params/internal.go
   M state/apiserver/common/setstatus.go
   M state/apiserver/common/setstatus_test.go
   D state/apiserver/machine/agent.go
   D state/apiserver/machine/agent_test.go
   D state/apiserver/machine/common_test.go
   M state/apiserver/machiner/machiner.go
   M state/apiserver/machiner/machiner_test.go
   M state/apiserver/root.go

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: