Merge lp://staging/~dimitern/juju-core/046-split-api-multiple-files-fixed into lp://staging/~juju/juju-core/trunk

Proposed by Dimiter Naydenov
Status: Merged
Merged at revision: 1240
Proposed branch: lp://staging/~dimitern/juju-core/046-split-api-multiple-files-fixed
Merge into: lp://staging/~juju/juju-core/trunk
Diff against target: 7640 lines (+3825/-3612)
26 files modified
state/api/client.go (+0/-578)
state/api/machine.go (+145/-0)
state/api/state.go (+77/-0)
state/api/unit.go (+48/-0)
state/api/watcher.go (+339/-0)
state/apiserver/admin.go (+20/-0)
state/apiserver/api_test.go (+30/-2069)
state/apiserver/apiserver.go (+0/-965)
state/apiserver/client.go (+212/-0)
state/apiserver/client_test.go (+442/-0)
state/apiserver/errors_test.go (+88/-0)
state/apiserver/login_test.go (+61/-0)
state/apiserver/machine.go (+132/-0)
state/apiserver/machine_test.go (+498/-0)
state/apiserver/perm_test.go (+584/-0)
state/apiserver/resource.go (+82/-0)
state/apiserver/root.go (+274/-0)
state/apiserver/scenario_test.go (+154/-0)
state/apiserver/server_test.go (+125/-0)
state/apiserver/state.go (+76/-0)
state/apiserver/state_test.go (+144/-0)
state/apiserver/unit.go (+41/-0)
state/apiserver/unit_test.go (+49/-0)
state/apiserver/user.go (+61/-0)
state/apiserver/utils.go (+53/-0)
state/apiserver/watcher.go (+90/-0)
To merge this branch: bzr merge lp://staging/~dimitern/juju-core/046-split-api-multiple-files-fixed
Reviewer Review Type Date Requested Status
Juju Engineering Pending
Review via email: mp+165687@code.staging.launchpad.net

Description of the change

state/api: Split to multiple files

To simplify maintenance and development, this
CL splits the API client and server packages
into multiple files. Tests are split as well.

Nothing new introduced, just mechanical.

I'm reproposing this, because the original CL
(https://codereview.appspot.com/9746043)
had issue. No changes here, just merged trunk.

https://codereview.appspot.com/9742044/

To post a comment you must log in.
Revision history for this message
Dimiter Naydenov (dimitern) wrote :

Reviewers: mp+165687_code.launchpad.net,

Message:
Please take a look.

Description:
state/api: Split to multiple files

To simplify maintenance and development, this
CL splits the API client and server packages
into multiple files. Tests are split as well.

Nothing new introduced, just mechanical.

I'm reproposing this, because the original CL
(https://codereview.appspot.com/9746043)
had issue. No changes here, just merged trunk.

https://code.launchpad.net/~dimitern/juju-core/046-split-api-multiple-files-fixed/+merge/165687

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/9742044/

Affected files:
   A [revision details]
   M state/api/apiclient.go
   M state/api/apierror.go
   M state/api/client.go
   A state/api/machine.go
   A state/api/state.go
   A state/api/unit.go
   A state/api/watcher.go
   A state/apiserver/admin.go
   M state/apiserver/api_test.go
   M state/apiserver/apierror.go
   state/apiserver/apiserver.go
   D state/apiserver/apiserver.go
   A state/apiserver/client.go
   A state/apiserver/client_test.go
   A state/apiserver/errors_test.go
   A state/apiserver/login_test.go
   A state/apiserver/machine.go
   A state/apiserver/machine_test.go
   A state/apiserver/perm_test.go
   A state/apiserver/resource.go
   A state/apiserver/root.go
   A state/apiserver/scenario_test.go
   A state/apiserver/server_test.go
   A state/apiserver/state.go
   A state/apiserver/state_test.go
   A state/apiserver/unit.go
   A state/apiserver/unit_test.go
   A state/apiserver/user.go
   A state/apiserver/utils.go
   A state/apiserver/watcher.go

Revision history for this message
Dimiter Naydenov (dimitern) wrote :

*** Submitted:

state/api: Split to multiple files

To simplify maintenance and development, this
CL splits the API client and server packages
into multiple files. Tests are split as well.

Nothing new introduced, just mechanical.

I'm reproposing this, because the original CL
(https://codereview.appspot.com/9746043)
had issue. No changes here, just merged trunk.

R=
CC=
https://codereview.appspot.com/9742044

https://codereview.appspot.com/9742044/

Revision history for this message
Dimiter Naydenov (dimitern) wrote :

On 2013/05/24 19:16:56, dimitern wrote:
> Please take a look.

Already approved as trivial in https://codereview.appspot.com/9746043/
This is the same change, but with fixed apiserver.go

https://codereview.appspot.com/9742044/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches