Code review comment for lp://staging/~dimitern/juju-core/027-state-supports-nonced-provisioning

Revision history for this message
William Reade (fwereade) wrote :

LGTM with the below

https://codereview.appspot.com/8561044/diff/7001/state/machine.go
File state/machine.go (right):

https://codereview.appspot.com/8561044/diff/7001/state/machine.go#newcode413
state/machine.go:413: notSetYet := D{{"$and", []D{
You don't need a $and, you can just have D{{"instanceid", ""}, {"nonce",
""}}

https://codereview.appspot.com/8561044/diff/7001/state/machine.go#newcode438
state/machine.go:438: // CheckProvisioned returns true, if the machine
was provisioned with
s/,//

https://codereview.appspot.com/8561044/diff/7001/state/machine.go#newcode439
state/machine.go:439: // an instance id and the given nonce.
s/an instance id and/

https://codereview.appspot.com/8561044/diff/7001/state/state.go
File state/state.go (right):

https://codereview.appspot.com/8561044/diff/7001/state/state.go#newcode192
state/state.go:192: return st.addMachine(series, instanceId,
BootstrapNonce, jobs)
Please test the change in InjectMachine

https://codereview.appspot.com/8561044/

« Back to merge proposal