Merge lp://staging/~dimitern/goose/nova-addresses3 into lp://staging/~gophers/goose/trunk

Reviewers: mp+145434_code.launchpad.net,

Message:
Please take a look.

Description:
trivial: better nova comments

Follow-up on https://codereview.appspot.com/7228058/, adding better
comments on the Nova ServerDetail struct's fields.

https://code.launchpad.net/~dimitern/goose/nova-addresses3/+merge/145434

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/7235058/

Affected files:
   A [revision details]
   M nova/nova.go

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision:
<email address hidden>
+New revision:
<email address hidden>

Index: nova/nova.go
=== modified file 'nova/nova.go'
--- nova/nova.go 2013-01-29 14:34:59 +0000
+++ nova/nova.go 2013-01-29 16:29:19 +0000
@@ -155,27 +155,41 @@
  // ServerDetail describes a server in more detail.
  // See:
http://docs.openstack.org/api/openstack-compute/2/content/Extensions-d1e1444.html#ServersCBSJ
  type ServerDetail struct {
- // First public IP address (if floating IP is assigned, otherwise "")
+ // AddressIPv4 and AddressIPv6 hold the first public IPv4 or IPv6
+ // address of the server, or "" if not floating IP is assigned.
   AddressIPv4 string
   AddressIPv6 string

- // Optional list of all IP addresses assigned to this
- // server, grouped by "network" name (e.g. "private",
- // "public" or a custom name)
+ // Addresses holds the list of all IP addresses assigned to this
+ // server, grouped by "network" name ("public", "private" or a
+ // custom name).
   Addresses map[string][]IPAddress

- Created string // creation timestamp
- Flavor Entity
- HostId string
- Id string
- Image Entity
- Links []Link
- Name string
- Progress int // completion % of current operation
- Status string // One of the Status* constants
+ // Created holds the creation timestamp of the server
+ // in RFC3339 format.
+ Created string
+
+ Flavor Entity
+ HostId string
+ Id string
+ Image Entity
+ Links []Link
+ Name string
+ // Progress holds the completion percentage of
+ // the current operation
+ Progress int
+
+ // Status holds the current status of the server,
+ // one of the Status* constants.
+ Status string
+
   TenantId string `json:"tenant_id"`
- Updated string // timestamp of last update
- UserId string `json:"user_id"`
+
+ // Updated holds the timestamp of the last update
+ // to the server in RFC3339 format.
+ Updated string
+
+ UserId string `json:"user_id"`
  }

  // ListServersDetail lists all details for available servers.

LGTM

https://codereview.appspot.com/7235058/diff/1/nova/nova.go
File nova/nova.go (right):

https://codereview.appspot.com/7235058/diff/1/nova/nova.go#newcode159
nova/nova.go:159: // address of the server, or "" if not floating IP is
assigned.
s/not/no/

https://codereview.appspot.com/7235058/

*** Submitted:

trivial: better nova comments

Follow-up on https://codereview.appspot.com/7228058/, adding better
comments on the Nova ServerDetail struct's fields.

R=rog
CC=
https://codereview.appspot.com/7235058

https://codereview.appspot.com/7235058/