Photos Lens

Merge lp://staging/~didrocks/unity-lens-photos/add-disabling-online-support into lp://staging/unity-lens-photos

  1. add-disabling-online-support
  2. Merge into trunk
Proposed by Didier Roche-Tolomelli
Status: Merged
Approved by: David Callé
Approved revision: 90
Merged at revision: 86
Proposed branch: lp://staging/~didrocks/unity-lens-photos/add-disabling-online-support
Merge into: lp://staging/unity-lens-photos
Diff against target: 257 lines (+96/-15)
6 files modified
src/facebook_scope.py (+16/-5)
src/flickr_scope.py (+16/-5)
src/picasa_scope.py (+16/-5)
tests/manual/facebook-photos.txt (+16/-0)
tests/manual/flickr-photos.txt (+16/-0)
tests/manual/picasa-photos.txt (+16/-0)
To merge this branch: bzr merge lp://staging/~didrocks/unity-lens-photos/add-disabling-online-support
Reviewer Review Type Date Requested Status
David Callé Approve
Review via email: mp+126631@code.staging.launchpad.net

Description of the change

Add disabling online search support on the facebook, flickr and picasa scopes

To post a comment you must log in.
Revision history for this message
David Callé (davidc3) wrote :

Looks good overall, but this needs to be fixed :

facebook_scope.py:61
- self._scope.connect("filters-changed", self.on_lens_active)
+ self._scope.connect("filters-changed", self.on_lens_active_or_preference_changed)

review: Needs Fixing
lp://staging/~didrocks/unity-lens-photos/add-disabling-online-support updated
90. By Didier Roche-Tolomelli

fix missing rename

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

fixed and pushed, please rereview :)

Revision history for this message
David Callé (davidc3) wrote :

Thanks Didier! I like the fact that you don't hide remote sources in the Sources filter when the setting is changed. Makes up for the OA integration vs No remote possible confusion :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches