Music Lens

Merge lp://staging/~didrocks/unity-lens-music/add-local-radio into lp://staging/unity-lens-music

add-local-radio
Merge into trunk

Proposed by Didier Roche-Tolomelli on 2012-06-25

Status:

Merged

Approved by:

Paweł Stołowski on 2012-07-02

Approved revision:

Merged at revision:

Proposed branch:

lp://staging/~didrocks/unity-lens-music/add-local-radio

Merge into:

lp://staging/unity-lens-music

Diff against target:

668 lines (+354/-74)

10 files modified

Makefile.am (+1/-1)
configure.ac (+1/-0)
src/categories.vala (+2/-1)
src/daemon.vala (+5/-1)
src/rhythmbox-collection.vala (+99/-70)
src/rhythmbox-scope.vala (+1/-1)
src/track.vala (+7/-0)
tests/Makefile.am (+45/-0)
tests/assertions.vapi (+23/-0)
tests/test-rhythmbox-parser.vala (+170/-0)

To merge this branch:

bzr merge lp://staging/~didrocks/unity-lens-music/add-local-radio

Related bugs:

Bug #969697: music lens doens't find rhythmbox radios	Undecided	Fix Released
Bug #1009069: Unknown albums can be shown if your language is not english	Low	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Paweł Stołowski (community)		2012-06-25	Approve on 2012-07-02
Review via email: mp+111875@code.staging.launchpad.net

Commit message

adds local radio detection from rhythmbox. The category will
only be placed after the "for purchase one" to be unobstrusive (LP: #969697)
Also fix the non translated "Unknown" album filter appearing for non english
users (LP: #1009069)
Add some tests for the parser part (radios and songs)

Description of the change

This branch adds local radio detection from rhythmbox. The category will
only be placed after the "for purchase one" to be unobstrusive (LP: #969697)

Also fix the non translated "Unknown" album filter appearing for non english
users (LP: #1009069)

Add some tests for the parser part (radios and songs)

Revision history for this message

Paweł Stołowski (stolowski) wrote on 2012-06-29:

1) I think we may need to adjust album handling logic in "search" method, as iradio records seem to have empty album names - I think we should skip album if TYPE == RADIO; see lines 654 - 665, i.e.
bool first_track_from_album = !(album in albums_list_nosearch);
...
if (first_track_from_album)
...
add_result (search.results_model, model, iter, ResultType.ALBUM, category_id);

2) Can you use TrackType as the type of Track - type_track instead of int?

review: Needs Fixing

lp://staging/~didrocks/unity-lens-music/add-local-radio updated on 2012-06-29