Ubuntu system image

Merge lp://staging/~didrocks/ubuntu-system-image/small-modifs into lp://staging/~barry/ubuntu-system-image/lp1212781

  1. small-modifs
  2. Merge into lp1212781
Proposed by Didier Roche-Tolomelli
Status: Merged
Merge reported by: Barry Warsaw
Merged at revision: not available
Proposed branch: lp://staging/~didrocks/ubuntu-system-image/small-modifs
Merge into: lp://staging/~barry/ubuntu-system-image/lp1212781
Diff against target: 329 lines (+112/-66)
3 files modified
systemimage/bindings.py (+1/-1)
systemimage/dbus.py (+22/-4)
systemimage/testing/dbus.py (+89/-61)
To merge this branch: bzr merge lp://staging/~didrocks/ubuntu-system-image/small-modifs
Reviewer Review Type Date Requested Status
Barry Warsaw Approve
Review via email: mp+181580@code.staging.launchpad.net

Description of the change

Misc mock issues fixes

To post a comment you must log in.
lp://staging/~didrocks/ubuntu-system-image/small-modifs updated
159. By Didier Roche-Tolomelli

no GetSetting/SetSetting needed

160. By Didier Roche-Tolomelli

comment is deprecated

161. By Didier Roche-Tolomelli

support version as a string instead of an int

162. By Didier Roche-Tolomelli

emit a SettingChanged signal if a setting key changed

Revision history for this message
Barry Warsaw (barry) wrote :

Thanks for the fixes and changes!

LP: #1215586 tracks the support for the array-of-dictionaries data type. I'll leave these commented out in my branch for now, so please resolve that issue when the u/i can handle this and I'll re-enable it in the client.

I fixed all the tests.

I had to restore the Reset method; it's used by the test suite due to peculiarities in the way the dbus service is launched through the testing infrastructure.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches