Merge lp://staging/~didrocks/ubuntu-scopes/suggest-tomboy into lp://staging/~submarine/ubuntu-scopes/tomboy

Proposed by Didier Roche-Tolomelli
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 17
Merged at revision: 17
Proposed branch: lp://staging/~didrocks/ubuntu-scopes/suggest-tomboy
Merge into: lp://staging/~submarine/ubuntu-scopes/tomboy
Diff against target: 24 lines (+3/-1)
2 files modified
debian/changelog (+2/-0)
debian/control (+1/-1)
To merge this branch: bzr merge lp://staging/~didrocks/ubuntu-scopes/suggest-tomboy
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Submarine Pending
Review via email: mp+154027@code.staging.launchpad.net

Commit message

Suggest tomboy, don't install it

Description of the change

Suggest tomboy, don't install it

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

that makes sense

Revision history for this message
James Henstridge (jamesh) wrote :

Does it make sense for the scope to be installable without Tomboy though? It looks like it won't work without it, so wouldn't it make more sense to keep the strong dependency and have other packages only suggest unity-scope-tomboy?

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

@James: the goal is to have all smart scopes available by default on the distro, so that once you download tomboy, you get the dash search for free.

My opinion is that we should think them as "hooks" ready for integration with the app, once you installed that app.

Revision history for this message
James Henstridge (jamesh) wrote :

Okay. Would making Tomboy recommend unity-scope-tomboy meet that goal?

If we do make this scope installable without Tomboy as this MP does, then it may need modification to run without Tomboy.

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

James: what about other distros? like kubuntu, xubuntu, edubuntu.
I don't think they want to have unity installed on the system if they apt-get install tomboy :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches