Merge lp://staging/~didrocks/ubiquity/minimal-package-list into lp://staging/ubiquity

Proposed by Didier Roche-Tolomelli
Status: Rejected
Rejected by: Iain Lane
Proposed branch: lp://staging/~didrocks/ubiquity/minimal-package-list
Merge into: lp://staging/ubiquity
Prerequisite: lp://staging/~didrocks/ubiquity/minimal-install
Diff against target: 121 lines (+103/-0)
3 files modified
debian/control (+8/-0)
debian/ubiquity-ubuntu-desktop-minimal.install (+1/-0)
debian/ubuntu-desktop/minimal_install_removal (+94/-0)
To merge this branch: bzr merge lp://staging/~didrocks/ubiquity/minimal-package-list
Reviewer Review Type Date Requested Status
Adam Conrad (community) Disapprove
Review via email: mp+337700@code.staging.launchpad.net

Description of the change

New minimal installation for ubuntu desktop

Add a new ubiquity-ubuntu-desktop-minimal package to offer a minimal installation option in ubuntu desktop.

Note that we need, as a workaround, listing principal rdepends and l10n
packages related to the ones we are removing to not have to relax their
dependencies pulling them back on finale installation.
This is until we move to subiquity and multiple layered rootfs.

As of today, normal installation is 4.1G and minimal is 3.5G.

Note: we'll need then to seed in live for ubuntu.bionic ubiquity-ubuntu-desktop-minimal. This way and the fact this is an additional package, only the ubuntu desktop flavor is impacted and present the minimal install option.

To post a comment you must log in.
Revision history for this message
Will Cooke (willcooke) wrote :

Could you add simple-scan to the list as well?

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Are you sure? I saw it more as an utility itself (like printing), that people may want even on a minimal install. Can add otherwise.

Revision history for this message
Will Cooke (willcooke) wrote :

> Are you sure? I saw it more as an utility itself (like printing), that people
> may want even on a minimal install. Can add otherwise.

It's easy to install if people want it. Scanning is enough of an edge case to not need by default. I agree printing is a requirement, but not scanning.

6591. By Didier Roche-Tolomelli

Adding simple-scan to the list

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

I added simple scan. There are other utilities like disk I guess to remove as well.

Revision history for this message
Adam Conrad (adconrad) wrote :

This doesn't belong in ubiquity, but in livecd-rootfs, where all the other package lists come from, which also allows you to generate it on the fly instead of having a static list. There's zero reason for this to be a package.

review: Disapprove
Revision history for this message
Adam Conrad (adconrad) wrote :

FWIW, when I say "there's zero reason for this to be a package", what I mean is that you should just be shipping a minimal-remove list on the ISO, the same as we do for, well, exactly how we already do removal of the live task. This should just be a second pass after live removal, using exactly the same mechanism.

Revision history for this message
Sebastien Bacher (seb128) wrote :

Adam, we went with that "alternative" way because we were asked to look at doing something this cycle and we don't currently have the resources in our team to do things the way you consider the proper one.

Didier who looked at that knows the details better but he's on holidays until feature freeze now but from what he said generating on the flight would requiring splitting the seeds and changing more projects to get the diff generated during the iso build and then used in casper. Is that approximatively right? Doing things this way would also make more difficult to remove libreoffice/thunderbird because they would be pulled back by their translations packages (but we could probably workaround that by making the translations depends on the softwares)

Would it be acceptable to keep the current solution if the list is moved to another package that ubiquity? If not would somebody from the installer team be able to help us to get the seed split and the diff generated and made available to the installer?

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

On 21 February 2018 at 15:42, Sebastien Bacher <email address hidden> wrote:
> Adam, we went with that "alternative" way because we were asked to look at doing something this cycle and we don't currently have the resources in our team to do things the way you consider the proper one.
>
> Didier who looked at that knows the details better but he's on holidays until feature freeze now but from what he said generating on the flight would requiring splitting the seeds and changing more projects to get the diff generated during the iso build and then used in casper. Is that approximatively right? Doing things this way would also make more difficult to remove libreoffice/thunderbird because they would be pulled back by their translations packages (but we could probably workaround that by making the translations depends on the softwares)
>
> Would it be acceptable to keep the current solution if the list is moved to another package that ubiquity? If not would somebody from the installer team be able to help us to get the seed split and the diff generated and made available to the installer?

I believe adam is asking for the "list" to be a file that is dropped
on the .iso by livecd-rootfs, similar to how .disk-info/ is injected,
instead of packaged in the archive as a package. Such that there is no
need to rebuild ubiquity, or any packages in the archive, to update
the list of things to remove, cause a simple iso respin alone will be
enough. (without even rebuilding squashfs).

I don't believe adam is asking for dynamically generating the static
list, but to simply move this static list into ubuntu-cdimage branch
which is code that is used to build desktop-live.iso. No need to
package the static list into a .deb.

--
Regards,

Dimitri.

Revision history for this message
Iain Lane (laney) wrote :

> I don't believe adam is asking for dynamically generating the static
> list, but to simply move this static list into ubuntu-cdimage branch
> which is code that is used to build desktop-live.iso. No need to
> package the static list into a .deb.

It's live-build + livecd-rootfs. I don't think moving it into ubuntu-cdimage would be helpful, unless we did something weird like pass it into the livefs build as extra metadata. I don't think we'd want to do that.

If we're going for short term solutions, maybe we can maintain this as a file on archive-team.internal/seeds / people.c.c/~ubuntu-archive/seeds that livecd-rootfs grabs during the build. AIUI those directories are clones of the appropriate seed branches, so we could stuff a file in there and grab it during live-build/auto/config or so.

Revision history for this message
Iain Lane (laney) wrote :

> If we're going for short term solutions, maybe we can maintain this as a file
> on archive-team.internal/seeds / people.c.c/~ubuntu-archive/seeds that livecd-
> rootfs grabs during the build. AIUI those directories are clones of the
> appropriate seed branches, so we could stuff a file in there and grab it
> during live-build/auto/config or so.

I'm going to try this in -proposed, so that I can get a test:

livecd-rootfs grabs SEEDMIRROR/SEED/BASE_SEED.minimal-remove if it exists, strips all comments from it and stuffs it in a file "filesystem.manifest-minimal-remove" which is outputted by the build.

ubuntu-cdimage downloads the file from the livefs build, and debian-cd includes it in the ISO. AFAICS this is what's needed. I'll make both of those changes and deploy the branches to nusakan.

Assuming that works, I'll get an ISO with the file in /casper and then I'll test on that ISO and change Didier's ubiquity branch to use the new file.

Revision history for this message
Iain Lane (laney) wrote :

Current livefs builds produce that file, and ISOs have it in the right place. e.g.:

https://launchpad.net/~ubuntu-cdimage/+livefs/ubuntu/bionic/ubuntu/+build/125165

Revision history for this message
Iain Lane (laney) wrote :

I guess this is "Rejected", but the actual list that didrocks came up with is in ubuntu-seeds/ubuntu.bionic now.

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: