Merge ~didrocks/ubiquity:master-fix-oem into ubiquity:master

Proposed by Didier Roche-Tolomelli
Status: Merged
Approved by: Jean-Baptiste Lallement
Approved revision: a9e7835e754f1f2e1d5d342baec244c6f8434bd9
Merged at revision: 70753bae0b6c2565ab1875f64006ff4b27d56d22
Proposed branch: ~didrocks/ubiquity:master-fix-oem
Merge into: ubiquity:master
Diff against target: 75 lines (+13/-0)
5 files modified
ubiquity/frontend/debconf_ui.py (+1/-0)
ubiquity/frontend/gtk_ui.py (+1/-0)
ubiquity/frontend/kde_ui.py (+1/-0)
ubiquity/frontend/noninteractive.py (+1/-0)
ubiquity/telemetry.py (+9/-0)
Reviewer Review Type Date Requested Status
Jean-Baptiste Lallement Approve
Review via email: mp+347043@code.staging.launchpad.net

Commit message

Only record OEM config when installing

Don't record telemetry data when doing stage 2 (user mode) as
it keeps an unused /target directory. (LP: #1773321)
Also, record OEM types. (LP: #1765693)

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

This was tested with GTK, KDE and debconf UI. Both with OEM and non OEM mode, including stage 2 (oem user mode).

Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

LGTM. Tested successfully on cosmic. Thanks!

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches