GNOME Shell

Merge lp://staging/~didrocks/gnome-shell/sound-above-100 into lp://staging/~ubuntu-desktop/gnome-shell/ubuntu

  1. sound-above-100
  2. Merge into ubuntu
Proposed by Didier Roche-Tolomelli
Status: Merged
Merged at revision: 47
Proposed branch: lp://staging/~didrocks/gnome-shell/sound-above-100
Merge into: lp://staging/~ubuntu-desktop/gnome-shell/ubuntu
Diff against target: 158 lines (+130/-0)
4 files modified
debian/changelog (+11/-0)
debian/patches/50_add_ubuntu_desktop_detect.patch (+38/-0)
debian/patches/70_allow_sound_above_100.patch (+79/-0)
debian/patches/series (+2/-0)
To merge this branch: bzr merge lp://staging/~didrocks/gnome-shell/sound-above-100
Reviewer Review Type Date Requested Status
Sebastien Bacher Pending
Review via email: mp+328067@code.staging.launchpad.net

Description of the change

* Add patch to allow setting volume above 100%:
    - debian/patches/70_allow_sound_above_100.patch, which allows the volume
      slider in the aggregatemenu to reflect and set correct current volume
      position. (LP: #1706524)

To post a comment you must log in.
lp://staging/~didrocks/gnome-shell/sound-above-100 updated
40. By Didier Roche-Tolomelli

Changed Forwarded to simpy Bug

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Pinging seb on that one as he did g-s-d review

lp://staging/~didrocks/gnome-shell/sound-above-100 updated
41. By Didier Roche-Tolomelli

Make it dependent on XDG_CURRENT_DESKTOP (which is what we are going
to use on other places).

42. By Didier Roche-Tolomelli

Add debian/patches/50_add_ubuntu_desktop_detect.patch to centralize
current desktop detection.

Revision history for this message
Amr Ibrahim (amribrahim1987) wrote :

There is a typo in the code. See the inline comment.

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Thanks! Staging it for the next upload :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches