gnome-control-center

Merge lp://staging/~didrocks/gnome-control-center/sound-above-100 into lp://staging/~ubuntu-desktop/gnome-control-center/ubuntu

  1. sound-above-100
  2. Merge into ubuntu
Proposed by Didier Roche-Tolomelli
Status: Merged
Merged at revision: 722
Proposed branch: lp://staging/~didrocks/gnome-control-center/sound-above-100
Merge into: lp://staging/~ubuntu-desktop/gnome-control-center/ubuntu
Diff against target: 190 lines (+161/-0) (has conflicts)
3 files modified
debian/changelog (+17/-0)
debian/patches/70_allow_sound_above_100.patch (+143/-0)
debian/patches/series (+1/-0)
Text conflict in debian/changelog
To merge this branch: bzr merge lp://staging/~didrocks/gnome-control-center/sound-above-100
Reviewer Review Type Date Requested Status
Sebastien Bacher Pending
Review via email: mp+328065@code.staging.launchpad.net

Description of the change

  * Add patch to expose settings allowing setting volume above 100%:
    - debian/patches/70_allow_sound_above_100.patch, adapt the patch from
      unity-control-center to only add a slightely reshaped UI (use of
      gtk switch and rephrasing). (LP: #1706524)

To post a comment you must log in.
lp://staging/~didrocks/gnome-control-center/sound-above-100 updated
722. By Didier Roche-Tolomelli

Changed Forwarded to simpy Bug

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Pinging seb on that one as he did g-s-d review

lp://staging/~didrocks/gnome-control-center/sound-above-100 updated
723. By Didier Roche-Tolomelli

Better wording

724. By Didier Roche-Tolomelli

Only show the above 100% volume option if:
1. you are in an ubuntu session
2. the selected output supports amplified volume. If so:
   present the settings to google that on and off. It will enable
   GNOME Shell and media keys to set the sound above 100%. If not
   enabled, volume and sliders are all capped to 100%.

725. By Didier Roche-Tolomelli

Rephase description in changelog and patch

726. By Didier Roche-Tolomelli

Make it dependent on XDG_CURRENT_DESKTOP (which is what we are going
to use on other places).

727. By Didier Roche-Tolomelli

Protect by detecting if gsettings schema is here

Revision history for this message
Amr Ibrahim (amribrahim1987) wrote :

There are typos in the code. See the inlined comments.

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

We don't change old changelogs, the rest is applied,thanks!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches