Ubuntu Help App

Merge lp://staging/~dholbach/help-app/prerequisites into lp://staging/~ubuntu-touch-coreapps-drivers/help-app/trunk

  1. prerequisites
  2. Merge into trunk
Proposed by Daniel Holbach
Status: Merged
Merged at revision: 57
Proposed branch: lp://staging/~dholbach/help-app/prerequisites
Merge into: lp://staging/~ubuntu-touch-coreapps-drivers/help-app/trunk
Diff against target: 32 lines (+11/-1)
1 file modified
edit-here/translations.py (+11/-1)
To merge this branch: bzr merge lp://staging/~dholbach/help-app/prerequisites
Reviewer Review Type Date Requested Status
Daniel Holbach (community) Approve
Nicholas Skaggs (community) Needs Fixing
Review via email: mp+251097@code.staging.launchpad.net

Description of the change

Give more information and fail more gently if prerequisites like po4a or polib are missing.

To post a comment you must log in.
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

One minor tweak

review: Needs Fixing
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

There is an unrelated issue with the HACKING doc, I'll ask you to sneak in:

You can find the updated HTML in ./app/www/. For instance, you can browse
the site in firefox with

firefox app/www/index.html

^^ This is incorrect now. We could say

firefox app/www/index.en-us.html

or

firefox app/www/index*.html

or remove the specific recommendation.

lp://staging/~dholbach/help-app/prerequisites updated
58. By Daniel Holbach

use shutil.which(), thanks Nick!

Revision history for this message
Daniel Holbach (dholbach) wrote :

app/www/index.html will be re-added through 1425025.

Revision history for this message
Daniel Holbach (dholbach) wrote :

<dholbach> balloons, the index.html will come back
 in fact I pushed a small branch to start work on bug 1425025
<ubot5> bug 1425025 in Help for Ubuntu for devices "Automatically load translated pages according to the user language" [High,Triaged] https://launchpad.net/bugs/1425025
<dholbach> can I merge the prerequisites branch now?
<balloons> dholbach, yep go for it

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches