Merge lp://staging/~dholbach/help-app/content-fixes2 into lp://staging/~ubuntu-touch-coreapps-drivers/help-app/trunk
Proposed by
Daniel Holbach
| Status: | Merged |
|---|---|
| Approved by: | David Planella |
| Approved revision: | 77 |
| Merged at revision: | 75 |
| Proposed branch: | lp://staging/~dholbach/help-app/content-fixes2 |
| Merge into: | lp://staging/~ubuntu-touch-coreapps-drivers/help-app/trunk |
| Diff against target: |
402 lines (+118/-95) 9 files modified
edit-here/Makefile (+1/-0) edit-here/content/pages/index.md (+1/-1) edit-here/po/de.po (+18/-15) edit-here/po/es.po (+18/-15) edit-here/po/fr.po (+18/-15) edit-here/po/help.pot (+8/-4) edit-here/po/it.po (+18/-15) edit-here/po/pt.po (+18/-15) edit-here/po/ro.po (+18/-15) |
| To merge this branch: | bzr merge lp://staging/~dholbach/help-app/content-fixes2 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| David Planella | Approve | ||
|
Review via email:
|
|||
To post a comment you must log in.
Revision history for this message
| Daniel Holbach (dholbach) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good to me. I actually noticed the missing index.html file for the web build on another MP I reviewed, but I thought it was intentional.
I think on the server it won't be needed, as it should serve the right $LANG.html file according to the user's browser language, but it won't hurt to have it to test translations locally.
Ack on adding the line break.