Ubuntu Developer Portal

Merge lp://staging/~dholbach/developer-ubuntu-com/queue-updates-1transaction into lp://staging/developer-ubuntu-com

queue-updates-1transaction
Merge into stable

Proposed by Daniel Holbach on 2015-09-04

Status:	Merged
Approved by:	David Callé on 2015-09-07
Approved revision:	140
Merged at revision:	145
Proposed branch:	lp://staging/~dholbach/developer-ubuntu-com/queue-updates-1transaction
Merge into:	lp://staging/developer-ubuntu-com
Diff against target:	184 lines (+51/-25) 1 file modified developer_portal/management/commands/import-external-docs-branches.py (+51/-25)
To merge this branch:	bzr merge lp://staging/~dholbach/developer-ubuntu-com/queue-updates-1transaction
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
David Callé (community)	2015-09-07	Approve on 2015-09-07
Ubuntu App Developer site developers	2015-09-04	Pending
Review via email: mp+270158@code.staging.launchpad.net

Commit message

Queue create/update/remove transactions and run them in one transaction at the end.

This hopefully avoid writes in different developer.u.c app units.

Description of the change

Queue create/update/remove transactions and run them in one transaction at the end. This hopefully avoid writes in different developer.u.c app units.

Change logging.ERROR to logging.DEBUG to see DB queries.

lp://staging/~dholbach/developer-ubuntu-com/queue-updates-1transaction updated on 2015-09-04

137. By Daniel Holbach on 2015-09-04: remove old Page.delete() statement
138. By Daniel Holbach on 2015-09-04: use db_actions.remove_page
139. By Daniel Holbach on 2015-09-04: merge trunk

Revision history for this message

Daniel Holbach (dholbach) wrote on 2015-09-04:

Test data to use:

Revision history for this message

Daniel Holbach (dholbach) wrote on 2015-09-07:

Some more explanation of what's happening:

Add a DBAction class with three methods: add_page() and remove_page() to add actions to the queue and run() to execute the actions. The queue uses a list, so the order is preserved (not that it should matter in our case).

The Page.objects...delete() call is replaced with remove_page().
The get_or_create_page() calls are replaced with add_page() calls.

For convenience, the call to .publish('en') is also moved into DBAction.run().

The constructors of the individual classes are all modified to pass our DBAction queue to all the places where it's required.

Hope that makes the review easier.

lp://staging/~dholbach/developer-ubuntu-com/queue-updates-1transaction updated on 2015-09-07