Ubuntu Developer Portal

Merge lp://staging/~dholbach/developer-ubuntu-com/generalise-external-docs-branches into lp://staging/~developer-ubuntu-com-dev/developer-ubuntu-com/snappy-docs-import

  1. generalise-external-docs-branches
  2. Merge into snappy-docs-import
Proposed by Daniel Holbach
Status: Merged
Merged at revision: 140
Proposed branch: lp://staging/~dholbach/developer-ubuntu-com/generalise-external-docs-branches
Merge into: lp://staging/~developer-ubuntu-com-dev/developer-ubuntu-com/snappy-docs-import
Diff against target: 434 lines (+151/-106)
5 files modified
developer_portal/admin.py (+5/-5)
developer_portal/management/commands/import-snappy-branches.py (+114/-82)
developer_portal/migrations/0003_add_external_docs_branches.py (+13/-13)
developer_portal/models.py (+8/-5)
locale/developer_portal.pot (+11/-1)
To merge this branch: bzr merge lp://staging/~dholbach/developer-ubuntu-com/generalise-external-docs-branches
Reviewer Review Type Date Requested Status
Michael Hall (community) Approve
Review via email: mp+266383@code.staging.launchpad.net
To post a comment you must log in.
lp://staging/~dholbach/developer-ubuntu-com/generalise-external-docs-branches updated
150. By Daniel Holbach

move is_snappy_branch for replacing links earlier in the code

151. By Daniel Holbach

get rid of is_snappy_branch distinction, instead derive SnappyLocalBranch and SnappyMarkdownFile for special handling

152. By Daniel Holbach

fix overview page title for non-current snappy docs branches

Revision history for this message
Michael Hall (mhall119) wrote :

The subclassing makes this much easier to follow and maintain, good work

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches