Merge lp://staging/~dholbach/developer-ubuntu-com/1568871 into lp://staging/developer-ubuntu-com
Proposed by
Daniel Holbach
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 209 | ||||
| Proposed branch: | lp://staging/~dholbach/developer-ubuntu-com/1568871 | ||||
| Merge into: | lp://staging/developer-ubuntu-com | ||||
| Diff against target: |
1785 lines (+840/-358) 18 files modified
md_importer/importer/article.py (+22/-60) md_importer/importer/process.py (+23/-17) md_importer/importer/publish.py (+143/-74) md_importer/importer/repo.py (+47/-87) md_importer/management/commands/import_md.py (+1/-1) md_importer/migrations/0003_add_herotour_template.py (+19/-0) md_importer/migrations/0004_move_from_page_object_to_url_string.py (+24/-0) md_importer/models.py (+8/-3) md_importer/tests/test_article.py (+155/-0) md_importer/tests/test_branch_fetch.py (+4/-4) md_importer/tests/test_branch_import.py (+53/-38) md_importer/tests/test_import_process.py (+268/-6) md_importer/tests/test_link_rewrite.py (+14/-13) md_importer/tests/test_misc.py (+6/-7) md_importer/tests/test_snappy_import.py (+7/-37) md_importer/tests/test_utils.py (+5/-4) md_importer/tests/test_website_import.py (+4/-4) md_importer/tests/utils.py (+37/-3) |
||||
| To merge this branch: | bzr merge lp://staging/~dholbach/developer-ubuntu-com/1568871 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ubuntu App Developer site developers | Pending | ||
|
Review via email:
|
|||
Description of the change
List of important changes (high level overview)
- added tests and assertions
- remove the implicit addition of redirects (we do this in JS now
and will have an app in the future)
- remove the special-casing of snappy vs non-snappy docs (it was
brittle and we will have to build proper versioning support
anyway)
- one way to look up pages
- proper distinction between drafts vs. public page objects
- refactor all page creation/updating logic into separate
ArticlePage class
- make index pages inherit from ArticlePage
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
