Canonical Click Reviewers tools (obsolete)

Merge lp://staging/~dholbach/click-reviewers-tools/scope-email into lp://staging/click-reviewers-tools

  1. scope-email
  2. Merge into trunk
Proposed by Daniel Holbach
Status: Merged
Merged at revision: 220
Proposed branch: lp://staging/~dholbach/click-reviewers-tools/scope-email
Merge into: lp://staging/click-reviewers-tools
Diff against target: 80 lines (+38/-0)
3 files modified
clickreviews/cr_lint.py (+10/-0)
clickreviews/tests/test_cr_lint.py (+21/-0)
debian/changelog (+7/-0)
To merge this branch: bzr merge lp://staging/~dholbach/click-reviewers-tools/scope-email
Reviewer Review Type Date Requested Status
Jamie Strandboge (community) Approve
Review via email: mp+229027@code.staging.launchpad.net

This proposal supersedes a proposal from 2014-07-31.

To post a comment you must log in.
Revision history for this message
Jamie Strandboge (jdstrand) wrote : Posted in a previous version of this proposal

This look fine except it is missing a corresponding test in clickreviews/tests/test_cr_lint.py. Can you add one (eg, add test_check_maintainer_email_special2()). Thanks!

review: Needs Fixing
Revision history for this message
Daniel Holbach (dholbach) wrote :

Done. Thanks.

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches