Canonical Click Reviewers tools (obsolete)

Merge lp://staging/~dholbach/click-reviewers-tools/1237974 into lp://staging/click-reviewers-tools

  1. 1237974
  2. Merge into trunk
Proposed by Daniel Holbach
Status: Merged
Merged at revision: 127
Proposed branch: lp://staging/~dholbach/click-reviewers-tools/1237974
Merge into: lp://staging/click-reviewers-tools
Diff against target: 63 lines (+18/-9)
1 file modified
clickreviews/cr_lint.py (+18/-9)
To merge this branch: bzr merge lp://staging/~dholbach/click-reviewers-tools/1237974
Reviewer Review Type Date Requested Status
Martin Albisetti (community) Approve
Review via email: mp+196294@code.staging.launchpad.net

This proposal supersedes a proposal from 2013-11-15.

To post a comment you must log in.
Revision history for this message
Martin Albisetti (beuno) wrote : Posted in a previous version of this proposal

8 + self.email = self.manifest['maintainer'].partition('<')[2].rstrip('>')
9 + self.is_core_app = (self.click_pkgname.startswith('com.ubuntu.') and \
10 + self.email == '<email address hidden>')

com.ubuntu.developer would match as well, if someone chose the <email address hidden> email address, right?

Revision history for this message
Martin Albisetti (beuno) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches