Ubuntu Developer Portal

Merge lp://staging/~developer-ubuntu-com-dev/developer-ubuntu-com/snappy-docs-import into lp://staging/developer-ubuntu-com

  1. snappy-docs-import
  2. Merge into stable
Proposed by Daniel Holbach
Status: Merged
Approved by: Daniel Holbach
Approved revision: 162
Merged at revision: 126
Proposed branch: lp://staging/~developer-ubuntu-com-dev/developer-ubuntu-com/snappy-docs-import
Merge into: lp://staging/developer-ubuntu-com
Diff against target: 507 lines (+422/-2)
6 files modified
developer_portal/admin.py (+18/-0)
developer_portal/management/commands/import-external-docs-branches.py (+309/-0)
developer_portal/migrations/0003_add_external_docs_branches.py (+62/-0)
developer_portal/models.py (+20/-1)
locale/developer_portal.pot (+11/-1)
requirements.txt (+2/-0)
To merge this branch: bzr merge lp://staging/~developer-ubuntu-com-dev/developer-ubuntu-com/snappy-docs-import
Reviewer Review Type Date Requested Status
Daniel Holbach (community) Approve
David Callé Pending
Review via email: mp+265004@code.staging.launchpad.net

Commit message

Add functionality to import external markdown docs (like snappy and snapcraft) automatically into developer site.

To post a comment you must log in.
Revision history for this message
Daniel Holbach (dholbach) wrote :

This is still WIP.

Revision history for this message
Daniel Holbach (dholbach) wrote :

David Callé noticed that SnappyMarkdownFile._make_snappy_mods doesn't work as expected.

review: Needs Fixing
Revision history for this message
Daniel Holbach (dholbach) wrote :

<davidcalle> dholbach, well, I'm not sure about the "Snappy" name for landing pages. I haven't found anything else. Oh, maybe the script itself should be renamed to not have snappy in its name.

Revision history for this message
David Callé (davidc3) wrote :

Added a few changes.

Lots of testing done with a dummy branch on the whole publication, page removal, doc name changes, etc. processes. Everything works great.

Revision history for this message
Daniel Holbach (dholbach) wrote :

<dholbach> davidcalle, I read the code again and I think I'm fine with it
 parts of it could be a bit simpler I feel, but for now I think it's good enough

review: Approve
Revision history for this message
Daniel Holbach (dholbach) wrote :

<davidcalle> dholbach, same for me. Let's merge it :) I'll try the staging deploy this afternoon.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches