Merge lp://staging/~developer-ubuntu-com-dev/developer-ubuntu-com/hero-tour-changes into lp://staging/developer-ubuntu-com
Status: | Merged |
---|---|
Approved by: | David Callé |
Approved revision: | 227 |
Merged at revision: | 197 |
Proposed branch: | lp://staging/~developer-ubuntu-com-dev/developer-ubuntu-com/hero-tour-changes |
Merge into: | lp://staging/developer-ubuntu-com |
Prerequisite: | lp://staging/~dholbach/developer-ubuntu-com/importer-post-deployment-fixes |
Diff against target: |
1977 lines (+1602/-25) 29 files modified
developer_portal/settings.py (+1/-0) md_importer/importer/__init__.py (+6/-0) md_importer/importer/article.py (+7/-3) md_importer/importer/process.py (+3/-1) md_importer/importer/publish.py (+14/-7) md_importer/importer/repo.py (+22/-10) md_importer/migrations/0002_hero_tour_changes.py (+24/-0) md_importer/models.py (+21/-0) md_importer/tests/data/website-test/out/get-started/as-dev/16.04/step2-setup-beaglebone-macos.md (+77/-0) md_importer/tests/data/website-test/out/get-started/as-dev/16.04/step2-setup-beaglebone-ubuntu.md (+49/-0) md_importer/tests/data/website-test/out/get-started/as-dev/16.04/step2-setup-beaglebone-windows.md (+53/-0) md_importer/tests/data/website-test/out/get-started/as-dev/16.04/step2-setup-dragonboard-macos.md (+74/-0) md_importer/tests/data/website-test/out/get-started/as-dev/16.04/step2-setup-dragonboard-ubuntu.md (+46/-0) md_importer/tests/data/website-test/out/get-started/as-dev/16.04/step2-setup-dragonboard-windows.md (+50/-0) md_importer/tests/data/website-test/out/get-started/as-dev/16.04/step2-setup-intel-nuc-macos.md (+73/-0) md_importer/tests/data/website-test/out/get-started/as-dev/16.04/step2-setup-intel-nuc-ubuntu.md (+73/-0) md_importer/tests/data/website-test/out/get-started/as-dev/16.04/step2-setup-intel-nuc-windows.md (+73/-0) md_importer/tests/data/website-test/out/get-started/as-dev/16.04/step2-setup-rpi2-macos.md (+74/-0) md_importer/tests/data/website-test/out/get-started/as-dev/16.04/step2-setup-rpi2-ubuntu.md (+46/-0) md_importer/tests/data/website-test/out/get-started/as-dev/16.04/step2-setup-rpi2-windows.md (+50/-0) md_importer/tests/data/website-test/out/get-started/as-dev/16.04/step3-get-familiar.md (+212/-0) md_importer/tests/data/website-test/out/get-started/as-dev/16.04/step4-first-snap.md (+8/-0) md_importer/tests/data/website-test/out/get-started/as-dev/16.04/step5-further-readings.md (+3/-0) md_importer/tests/data/website-test/out/get-started/as-dev/index.html (+63/-0) md_importer/tests/test_branch_import.py (+66/-0) md_importer/tests/test_link_rewrite.py (+4/-2) md_importer/tests/test_website_import.py (+72/-0) md_importer/tests/utils.py (+4/-2) templates/snappy_hero_tour.html (+334/-0) |
To merge this branch: | bzr merge lp://staging/~developer-ubuntu-com-dev/developer-ubuntu-com/hero-tour-changes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
David Callé | Needs Fixing | ||
Review via email:
|
This proposal supersedes a proposal from 2016-03-08.
Description of the change
### Template ###
Template details for testing purposes:
The template currently assumes the following snappy page tree, where all the pages starting from "ubuntu-
snappy
get-started
16-04 (redirect to ubuntu-
15-10 (redirect to ubuntu-
The template provides a shell for content, this content is CMS editable and/or imported via the md importer.
Examples:
- http://
- http://
The ubuntu-
- The snappy version selector needs name="version"
- Each radio input needs name="host" (for host choices) or name="target" (for board choices)
V0 of the tour landing page: http://
Everything looks and tests are very nice!
Except this failing one:
======= ======= ======= ======= ======= ======= ======= ======= ======= ======= tests.test_ link_rewrite. TestLinkRewrite ) ------- ------- ------- ------- ------- ------- ------- ------- ------- david/dev/ duc/mtotrunk_ mar16/developer -ubuntu- com/md_ importer/ tests/test_ link_rewrite. py", line 37, in runTest assertEqual( link.attrs[ 'href'] , '/file2')
FAIL: runTest (md_importer.
-------
Traceback (most recent call last):
File "/home/
self.
AssertionError: u'/en/file2/' != '/file2'