Ubuntu Developer Portal

Merge lp://staging/~developer-ubuntu-com-dev/developer-ubuntu-com/get-gadget-snaps into lp://staging/developer-ubuntu-com

get-gadget-snaps
Merge into stable

Proposed by David Callé on 2016-05-12

Status:	Merged
Approved by:	David Callé on 2016-05-18
Approved revision:	230
Merged at revision:	222
Proposed branch:	lp://staging/~developer-ubuntu-com-dev/developer-ubuntu-com/get-gadget-snaps
Merge into:	lp://staging/developer-ubuntu-com
Diff against target:	245 lines (+89/-22) 8 files modified developer_portal/migrations/0002_update_rawhtml_data_type.py (+19/-0) store_data/cms_plugins.py (+10/-2) store_data/management/store/api.py (+6/-9) store_data/migrations/0003_make_iconurl_optional.py (+19/-0) store_data/models.py (+1/-1) store_data/static/img/official.svg (+10/-0) templates/gadget_snap_list.html (+15/-8) templates/gadget_snap_shortlist.html (+9/-2)
To merge this branch:	bzr merge lp://staging/~developer-ubuntu-com-dev/developer-ubuntu-com/get-gadget-snaps
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Daniel Holbach (community)		2016-05-12	Needs Fixing on 2016-05-12
Review via email: mp+294502@code.staging.launchpad.net

Description of the change

Add gadget type snaps from the snap store to the existing oem type snaps list.

lp://staging/~developer-ubuntu-com-dev/developer-ubuntu-com/get-gadget-snaps updated on 2016-05-12

222. By David Callé on 2016-05-12: Give the possibility for the icon_url to be null, make migrations

Revision history for this message

Daniel Holbach (dholbach) wrote on 2016-05-12:

Can you rename the migration scripts (both) to something more descriptive?

review: Approve

Revision history for this message

Daniel Holbach (dholbach) wrote on 2016-05-12:

Apart from that: great work so far. The presentation is something which would be good to change too.

review: Needs Fixing

lp://staging/~developer-ubuntu-com-dev/developer-ubuntu-com/get-gadget-snaps updated on 2016-05-14

223. By Daniel Holbach on 2016-05-14: rename migrations to be more descriptive
224. By Daniel Holbach on 2016-05-14: order by release
225. By Daniel Holbach on 2016-05-14: show which release a snap is available for
226. By Daniel Holbach on 2016-05-14: show which release a snap is available for (on short gadget snap list)
227. By Daniel Holbach on 2016-05-14: indicate if snap is officially supported

Revision history for this message

Daniel Holbach (dholbach) wrote on 2016-05-14:

David: I made a couple of changes which reflect what we talked about earlier (official support, indicate which release is supported). Now we just need to make it look pretty. :-)

lp://staging/~developer-ubuntu-com-dev/developer-ubuntu-com/get-gadget-snaps updated on 2016-05-16