Merge lp://staging/~deryck/launchpad/private-bugs-on-overview-739455 into lp://staging/launchpad
| Status: | Merged |
|---|---|
| Approved by: | Deryck Hodge |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 12934 |
| Proposed branch: | lp://staging/~deryck/launchpad/private-bugs-on-overview-739455 |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
13 lines (+1/-2) 1 file modified
lib/lp/bugs/templates/bugtarget-portlet-latestbugs.pt (+1/-2) |
| To merge this branch: | bzr merge lp://staging/~deryck/launchpad/private-bugs-on-overview-739455 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Curtis Hovey (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
[r=sinzui][bug=739455] Remove caching of latest bugs on project overview pages.
Description of the change
This branch fixes bug 739455, which reports that the latest bugs list on project overview pages could continue to list a bug after it's been marked private. This was due to memcached caching. This branch removes that caching.
I chose to remove the caching for a number of reasons. I don't think we're using memcache well enough to get much benefit from it, and Robert notes in the bug that those pages are still given to timeouts anyway. This is one portlet, so we can certainly watch if this affects the timeouts there.
Also, we didn't have any test coverage of the caching of this portlet or the bugs it listed. If I'm wrong, I would love someone to correct me. I did a pretty liberal test regex and didn't find any failures. ec2 test will certainly catch this if I'm wrong.
Assuming I'm correct and there is no coverage for this portlet, I think this is bad, but maybe others don't think this is worth testing, given the missing coverage. I don't want to slow down an easy fix for adding these tests, though. I can open a bug about the missing test. I can also add them now if the reviewer wishes to push back hard enough. :-) But obviously, I don't think this is required now, given this branch removes an untested feature anyway.
Thanks in advance for the review!
| Deryck Hodge (deryck) wrote | # |
The test is in implicit in
lib/
And it must remain because some of the portlets under test are still cached.