Merge lp://staging/~deryck/launchpad/no-linky-abandoned-branches-559325 into lp://staging/launchpad
Proposed by
Deryck Hodge
| Status: | Rejected |
|---|---|
| Rejected by: | Deryck Hodge |
| Proposed branch: | lp://staging/~deryck/launchpad/no-linky-abandoned-branches-559325 |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
61 lines (+32/-1) 2 files modified
lib/lp/bugs/browser/bugtask.py (+4/-1) lib/lp/bugs/stories/bugs/xx-link-bug-to-branch.txt (+28/-0) |
| To merge this branch: | bzr merge lp://staging/~deryck/launchpad/no-linky-abandoned-branches-559325 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Aaron Bentley (community) | Disapprove | ||
|
Review via email:
|
|||
Commit message
Do not list abandon branches as linked branches on a bug page.
Description of the change
This branch makes sure that branches marked as abandoned are not listed on a bug page. The page test has been extended to demonstrate that this actually happens as it should.
./bin/test -cvvt xx-link-
To post a comment you must log in.
Unmerged revisions
- 10649. By Deryck Hodge
-
Test that abandon branches don't appear on a bug page.
- 10648. By Deryck Hodge
-
Do not include abandoned branches in linked_branches.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I think that hiding the branch is not the right approach. The fact that the original developer stopped working on it does not imply that the branch is useless, and we should err on the side of showing things that may be useful.
However, we should prominently display the abandoned status. We might also want to reduce the visibility of the merge proposal, or hide it entirely. It implies that the branch is in development, which is at odds with the branch's status. (We should still allow traversal to the merge proposal from the branch page itself.)
If there were no merge proposal, the Abandoned status would be prominent, so as a first cut, I suggest that we ignore the merge proposals of abandoned branches in this display.