Merge lp://staging/~deryck/launchpad/minify-app-specific-js-592795 into lp://staging/launchpad
Proposed by
Deryck Hodge
| Status: | Merged |
|---|---|
| Approved by: | Deryck Hodge |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 11009 |
| Proposed branch: | lp://staging/~deryck/launchpad/minify-app-specific-js-592795 |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
55 lines (+19/-4) 2 files modified
Makefile (+1/-1) utilities/lp-deps.py (+18/-3) |
| To merge this branch: | bzr merge lp://staging/~deryck/launchpad/minify-app-specific-js-592795 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Māris Fogels (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Ensure JavaScript included from app-specific modules is minified.
Description of the change
This gets js files that live in app-specific javascript directories
minified. They are not currently minified, and while moving bugs js
code to lp.bugs.javascript, I got the build error about launchpad.js
being over 500k.
I've run the fix by rockstar who wrote the original lp-dep script,
and mars since he maintains the front-end build infrastructure. Both
seemed generally fine with the approach here, after some small
discussion on IRC.
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files:
Makefile
utilities/
To post a comment you must log in.
Revision history for this message
| Deryck Hodge (deryck) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Hi Deryck,
I assume the log_none() monkey patch is because this script's output to STDOUT is a programmatic input to another script? It would be nice to put a comment before if that is the case.
I assume you ran this through 'xvfb-run make jscheck'?
And thanks for the Makefile fix.
With the added comment, r=mars.
Maris