Bazaar

Merge lp://staging/~dennis-benzinger/bzr/735417-BZR_PROGRESS_BAR-help-update into lp://staging/bzr

  1. 735417-BZR_PROGRESS_BAR-help-update
  2. Merge into bzr.dev
Proposed by Dennis Benzinger
Status: Merged
Approved by: Jelmer Vernooij
Approved revision: 6046
Merge reported by: Vincent Ladeuil
Merged at revision: not available
Proposed branch: lp://staging/~dennis-benzinger/bzr/735417-BZR_PROGRESS_BAR-help-update
Merge into: lp://staging/bzr
Diff against target: 13 lines (+1/-2)
1 file modified
bzrlib/help_topics/__init__.py (+1/-2)
To merge this branch: bzr merge lp://staging/~dennis-benzinger/bzr/735417-BZR_PROGRESS_BAR-help-update
Reviewer Review Type Date Requested Status
Andrew Bennetts Approve
Review via email: mp+69350@code.staging.launchpad.net

Description of the change

Updated description of BZR_PROGRESS_BAR in "bzr help env-variables" to fix bug 735417.

To post a comment you must log in.
Revision history for this message
Andrew Bennetts (spiv) wrote :

Looks good to me.

[must-do] Please execute Canonical's Contributor License Agreement: <http://www.canonical.com/contributors>.

[tweak] This should have an entry in doc/en/release-notes/bzr-2.5.txt giving you credit for fixing the bug :) Whoever lands this can take care of that for you.

[observation] This would be a reasonable fix to be backported to lp:bzr/2.4 as well, I think. (Again, it's not necessary for you to do this.)

Thanks!

review: Approve
Revision history for this message
Dennis Benzinger (dennis-benzinger) wrote :

1. I've just executed the agreement. You should get a mail soon.

2. Should I add it to the release notes?

3. What's the right way to backport my fix? Can I just merge my change from my branch or from bzr.dev when it has landed there?

Revision history for this message
Martin Pool (mbp) wrote :

I'll take of those things for you, Dennis.

If you feel like doing more here, https://bugs.launchpad.net/bzr/+bug/746993 would be great.

Revision history for this message
Martin Pool (mbp) wrote :

rebased to lp:bzr/2.4 and sent to pqm

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.