lp://staging/~declanmg/bzr/264275-fix

Branch merges

Propose for merging

No branches dependent on this one.

On hold for merging into lp://staging/bzr

Robert Collins (community): Needs Fixing on 2009-11-26

John A Meinel: Pending requested 2009-11-23

Diff: 145 lines (+91/-0)

4 files modified

bzrlib/builtins.py (+25/-0)
bzrlib/errors.py (+5/-0)
bzrlib/tests/blackbox/test_add.py (+55/-0)
bzrlib/tests/test_errors.py (+6/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #264275: bazaar internal error if adding file in a linked directory

Medium

Confirmed

Link a bug report

Related blueprints

4743. By jack <jack@pixie> on 2009-11-22

Added tests for is_realpath_outside_tree().

4742. By jack <jack@pixie> on 2009-11-22

Made some post-review changes as requested (more to do) as follows...

* Renamed overly verbose error class
* Made all text lines less than 80 chars long
* Added docstring to is_realpath_outside_tree()
* Removed use of os.mkdir where appropriate in tests

4741. By jack <jack@pixie> on 2009-11-08

Tiny refactor. Send for review now.

4740. By jack <jack@pixie> on 2009-11-08

Moved tests from wip test to test_add.py. Bug 264275 ready for comment.

4739. By jack <jack@pixie> on 2009-11-08

Fixed typos in tests.

4738. By jack <jack@pixie> on 2009-11-08

Finished writing test logic.

4737. By jack <jack@pixie> on 2009-11-08

Added an error test for bug 264275 fix.

4736. By jack <jack@pixie> on 2009-11-08

Refactored code to reveal intent and tidied tests.

4735. By jack <jack@pixie> on 2009-10-31

Added a test concerning adding a file under a symlinked dir outside working copy

4734. By Declan McGrath <jack@jack> on 2009-10-18

Trying to target the specific test case more accurately. Still WIP.