Merge lp://staging/~deadlight/ubuntu-manpage-repository/design-update into lp://staging/ubuntu-manpage-repository

Proposed by Karl Williams
Status: Merged
Merged at revision: 224
Proposed branch: lp://staging/~deadlight/ubuntu-manpage-repository/design-update
Merge into: lp://staging/ubuntu-manpage-repository
Diff against target: 237 lines (+83/-77)
6 files modified
www/above1.html (+10/-10)
www/above2.html (+46/-45)
www/assets/light/css/styles.css (+5/-0)
www/below.html (+10/-10)
www/functions.js (+3/-1)
www/index_real.html (+9/-11)
To merge this branch: bzr merge lp://staging/~deadlight/ubuntu-manpage-repository/design-update
Reviewer Review Type Date Requested Status
Joshua Powers (community) Approve
Anthony Dillon (community) Approve
Review via email: mp+364106@code.staging.launchpad.net

Description of the change

- Updated to Vanilla-framework 1.8.1
  - Various CSS, HTML and JavaScript changes for the following:
    - Updated the look of the homepage
    - Hide the sidebar when there's no content
    - Make the listing full-width when the sidebar is hidden

To post a comment you must log in.
Revision history for this message
Karl Williams (deadlight) wrote :

QA instructions
--------------

Open [your container IP]:8080
Check the homepage is correctly styled
Check a listing page (one of the top-nav items) and see that it's full width
Open a manpage in that list and see that there's a sidebar table of contents

225. By Karl Williams <email address hidden>

Update markup classes for homepage

Revision history for this message
Anthony Dillon (ya-bo-ng) wrote :

LGTM +1 just need to add a line break to the homepage title.

review: Approve
Revision history for this message
Joshua Powers (powersj) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches