Merge lp://staging/~deadlight/canonical-identity-provider/registration-templates into lp://staging/~deadlight/canonical-identity-provider/vanilla

Proposed by Karl Williams
Status: Merged
Approved by: Karl Williams
Approved revision: 1718
Merged at revision: 1719
Proposed branch: lp://staging/~deadlight/canonical-identity-provider/registration-templates
Merge into: lp://staging/~deadlight/canonical-identity-provider/vanilla
Prerequisite: lp://staging/~deadlight/canonical-identity-provider/notifications-and-errors
Diff against target: 241 lines (+74/-104)
4 files modified
src/identityprovider/static_src/scss/styles.scss (+5/-0)
src/webui/templates/registration/logout_to_confirm.html (+6/-4)
src/webui/templates/registration/two_factor_information.html (+7/-7)
src/webui/templates/registration/twofactor.html (+56/-93)
To merge this branch: bzr merge lp://staging/~deadlight/canonical-identity-provider/registration-templates
Reviewer Review Type Date Requested Status
Anthony Dillon (community) Approve
Review via email: mp+372078@code.staging.launchpad.net

Description of the change

Converted the remaining registration templates to Vanilla

QA:
In terminal 1:
- npm i
- ./node_modules/gulp/bin/gulp.js sass
- source env/bin/activate
- make start-db
- make run
- Visit http://[CONTAINER IP]:8000/
- Create an account and login
- Add an SSO source
- Go to and test http://[CONTAINER IP]:8000/two_factor_auth?next=/
- Go to http://[CONTAINER IP]:8000/+logout-to-confirm and check the page renders properly

To post a comment you must log in.
Revision history for this message
Anthony Dillon (ya-bo-ng) wrote :

LGTM one small comment

review: Approve
1719. By Karl Williams

Make two factor form error use Vanilla form validation styles

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: