Merge lp://staging/~deadlight/canonical-identity-provider/notifications-and-errors into lp://staging/~deadlight/canonical-identity-provider/vanilla

Proposed by Karl Williams
Status: Merged
Merged at revision: 1717
Proposed branch: lp://staging/~deadlight/canonical-identity-provider/notifications-and-errors
Merge into: lp://staging/~deadlight/canonical-identity-provider/vanilla
Diff against target: 336 lines (+107/-103)
7 files modified
src/webui/templates/403-csrf.html (+26/-27)
src/webui/templates/404-no-token.html (+12/-12)
src/webui/templates/404.html (+8/-10)
src/webui/templates/500.html (+28/-22)
src/webui/templates/cookies.html (+5/-5)
src/webui/templates/limitexceeded.html (+13/-13)
src/webui/templates/readonly.html (+15/-14)
To merge this branch: bzr merge lp://staging/~deadlight/canonical-identity-provider/notifications-and-errors
Reviewer Review Type Date Requested Status
Anthony Dillon (community) Approve
Review via email: mp+372065@code.staging.launchpad.net

Description of the change

Converted a selection of small templates to Vanilla styling

QA:
- npm i
- ./node_modules/gulp/bin/gulp.js sass
- source env/bin/activate
- make start-db
- make run
- Change line 19 of settings_devel.py to "DEBUG = False"
- Visit http://[CONTAINER IP]:8000/NOT-A-REAL-PAGE and see the 404 message

Others are harder to view in development but use a similar template

To post a comment you must log in.
Revision history for this message
Anthony Dillon (ya-bo-ng) wrote :

Few comments in the code.

review: Needs Fixing
1717. By Karl Williams

HTML updates for error pages

Revision history for this message
Anthony Dillon (ya-bo-ng) wrote :

LGTM +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: