Merge lp://staging/~deadlight/canonical-identity-provider/emails into lp://staging/canonical-identity-provider/release
Proposed by
Karl Williams
| Status: | Merged |
|---|---|
| Merge reported by: | Karl Williams |
| Merged at revision: | not available |
| Proposed branch: | lp://staging/~deadlight/canonical-identity-provider/emails |
| Merge into: | lp://staging/canonical-identity-provider/release |
| Prerequisite: | lp://staging/~deadlight/canonical-identity-provider/account-activity |
| Diff against target: |
217 lines (+89/-97) 2 files modified
package.json (+1/-1) src/webui/templates/account/emails.html (+88/-96) |
| To merge this branch: | bzr merge lp://staging/~deadlight/canonical-identity-provider/emails |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Anthony Dillon (community) | Approve | ||
| Ubuntu One hackers | Pending | ||
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2019-08-19.
Description of the change
Updated the vanilla version and styled the email settings page
QA:
- npm i
- ./node_
- source env/bin/activate
- make start-db
- make run
- Visit http://[CONTAINER IP]:8000/ in your browser
- Create an account using the form
- Go to http://[CONTAINER IP]:8000/+emails and try adding new addresses, etc.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM, few comments inline.