Merge lp://staging/~dcaro/clicompanion/fix-923535 into lp://staging/clicompanion

Hi David!

Sorry for long time before review, I have much work with preparation for very important for me contest.

I have applied your path, but I can't see how it work. After typing http://www.google.com in terminal and click [enter], it isn't appear as link and isn't clickable.

Please explain, how your path should work - and thank you for working on it!

Marek

You have to go to the plugins configuration and enable them first (that's because the config file is not overwrited if it exists).

So for this to work, just go to Preferences -> Plugins and double click the checkbox of the StandardURLs plugin and LaunchpadURL plugin. After this (inmediatly, you don't need to restart) when you pass the mouse over a recognized url, it will be underscored, in that moment you can press ctrl+click and that will open a tab/window of your preferred browser.

I hope you like it!

OK, thanks for explain. I will try it now.

I found small bugs:

After typing lp:clicompanion and pressing [enter], then created link is '
https://code.launchpad.net/+branch/clicompanion:%20nie%20znaleziono%20poleceniauser@user-GX780-GT780-GT780DX:~/clicompanion/clicompanion$%20%5EC'
created from underlined ' lp:clicompanion: nie znaleziono polecenia \n
user@user-GX780-GT780-GT780DX:~/clicompanion/clicompanion'.

After typing lp:12312 and pressing [enter], I have two links - one correct
to bug, and one '
https://code.launchpad.net/+branch/12122:%20nie%20znaleziono%20poleceniauser@user-GX780-GT780-GT780DX:~/clicompanion/clicompanion$%20%5EC
'

Fixed, the regexp matching launchpad branches was too permissive and false positives were matched. It should be fixed now (it's a lot more strict, so maybe real urls that have some strange chars in them are not matched correctly, but now most of urls will match).

Also you don't need to hit enter for the url to get underscored ;)

2012/3/4 David Caro <email address hidden>

> Fixed, the regexp matching launchpad branches was too permissive and false
> positives were matched. It should be fixed now (it's a lot more strict, so
> maybe real urls that have some strange chars in them are not matched
> correctly, but now most of urls will match).
>
> Also you don't need to hit enter for the url to get underscored ;)
>
> --
> https://code.launchpad.net/~dcaro/clicompanion/fix-923535/+merge/90633<https://code.launchpad.net/%7Edcaro/clicompanion/fix-923535/+merge/90633>
> You are reviewing the proposed merge of lp:~dcaro/clicompanion/fix-923535
> into lp:clicompanion.
>

OK, I will test it soon.

Tested - problems solved.

Thanks for implementing nice feature!