Merge lp://staging/~dbarth/indicator-network/menu-structure into lp://staging/~indicator-applet-developers/indicator-network/indicator-network

Proposed by David Barth
Status: Merged
Merged at revision: 2
Proposed branch: lp://staging/~dbarth/indicator-network/menu-structure
Merge into: lp://staging/~indicator-applet-developers/indicator-network/indicator-network
Diff against target: 297 lines (+168/-16)
4 files modified
src/connman.h (+1/-0)
src/indicator-network-service.c (+152/-13)
src/indicator-network-service.h (+7/-0)
src/service.c (+8/-3)
To merge this branch: bzr merge lp://staging/~dbarth/indicator-network/menu-structure
Reviewer Review Type Date Requested Status
Kalle Valo (community) Approve
Review via email: mp+26028@code.staging.launchpad.net

Description of the change

Adds a menu structure, makes sure available networks are updated within that structure. Also provide a toggle reflecting and commanding the wifi status (enable / disable)

To post a comment you must log in.
Revision history for this message
Kalle Valo (kvalo) wrote :

/* FIXME: that should only be updated once we get the corresponding confirmation signal from connman */

We should follow AvailableTechnologies and EnabledTechnologies and change the states accordingly. But connman 0.52 has a bug which affects this.

Otherwise looks very cool, thank you. Approved.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches