Indicator Date and Time

Merge lp://staging/~dbarth/indicator-datetime/mute-notifications-15.04 into lp://staging/indicator-datetime/15.04

  1. mute-notifications-15.04
  2. Merge into trunk.15.04
Proposed by David Barth
Status: Needs review
Proposed branch: lp://staging/~dbarth/indicator-datetime/mute-notifications-15.04
Merge into: lp://staging/indicator-datetime/15.04
Diff against target: 104 lines (+53/-2)
2 files modified
debian/control (+2/-0)
src/snap.cpp (+51/-2)
To merge this branch: bzr merge lp://staging/~dbarth/indicator-datetime/mute-notifications-15.04
Reviewer Review Type Date Requested Status
Sebastien Bacher Needs Fixing
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+282992@code.staging.launchpad.net

Commit message

don't show snap/appointments if the calendar app is blacklisted in system notifications settings
(backported from trunk mp)

Description of the change

don't show snap/appointments if the calendar app is blacklisted in system notifications settings
(backported from trunk mp)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:424
http://jenkins.qa.ubuntu.com/job/indicator-datetime-15.04-ci/22/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-15.04-vivid-amd64-ci/22
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-15.04-vivid-armhf-ci/22
        deb: http://jenkins.qa.ubuntu.com/job/indicator-datetime-15.04-vivid-armhf-ci/22/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-datetime-15.04-ci/22/rebuild

review: Approve (continuous-integration)
Reply
lp://staging/~dbarth/indicator-datetime/mute-notifications-15.04 updated
425. By David Barth

make ^Cde a bit more robust, and add some debug statements

426. By David Barth

fix

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:426
http://jenkins.qa.ubuntu.com/job/indicator-datetime-15.04-ci/23/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-15.04-vivid-amd64-ci/23
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-15.04-vivid-armhf-ci/23
        deb: http://jenkins.qa.ubuntu.com/job/indicator-datetime-15.04-vivid-armhf-ci/23/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-datetime-15.04-ci/23/rebuild

review: Approve (continuous-integration)
Reply
lp://staging/~dbarth/indicator-datetime/mute-notifications-15.04 updated
427. By David Barth

adjust title and notification icon according to the event type

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:427
http://jenkins.qa.ubuntu.com/job/indicator-datetime-15.04-ci/24/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-datetime-15.04-vivid-amd64-ci/24/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-datetime-15.04-vivid-armhf-ci/24/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-datetime-15.04-ci/24/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:427
http://jenkins.qa.ubuntu.com/job/indicator-datetime-15.04-ci/25/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-datetime-15.04-vivid-amd64-ci/25/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-datetime-15.04-vivid-armhf-ci/25/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-datetime-15.04-ci/25/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Sebastien Bacher (seb128) wrote :

thanks for the work, the "adjust title and notification icon according to the event type" seems a different issue, could you use a different merge request/branch for it?
the commit message states "don't show snap/appointments", could you give some more details? does it concern the indicator menu or the reminders?

review: Needs Fixing
Reply

Unmerged revisions

427. By David Barth

adjust title and notification icon according to the event type

426. By David Barth

fix

425. By David Barth

make ^Cde a bit more robust, and add some debug statements

424. By David Barth

don't show snap/appointments if the calendar app is blacklisted in system notifications settings

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches