freerdp

Merge lp://staging/~dbarth/freerdp/wm-class-support into lp://staging/ubuntu/raring/freerdp

  1. wm-class-support
  2. Merge into raring
Proposed by David Barth
Status: Work in progress
Proposed branch: lp://staging/~dbarth/freerdp/wm-class-support
Merge into: lp://staging/ubuntu/raring/freerdp
Diff against target: 100 lines (+88/-0)
2 files modified
debian/patches/add-wm-class.diff (+87/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp://staging/~dbarth/freerdp/wm-class-support
Reviewer Review Type Date Requested Status
Luke Yelavich (community) Needs Fixing
Rex Tsai Pending
Ubuntu branches Pending
Review via email: mp+155461@code.staging.launchpad.net

Description of the change

Add support for the StartupWMClass property. This lets bamf/unity properly match and distinguish remote applications launched by xfreerdp.

To post a comment you must log in.
Revision history for this message
Luke Yelavich (themuso) wrote :

Looking at the changelog, I am unsure as to whether you are targetting this at quantal, in which case an SRU is needed, or raring. In addition, there is also an extra component to the version which shouldn't be there. Your change also doesn't appear to be based on the raring branch.

review: Needs Fixing
Reply
lp://staging/~dbarth/freerdp/wm-class-support updated
24. By David Barth

removing the changelog to help with raring integration

Revision history for this message
David Barth (dbarth) wrote :

I cleaned up the patch, and most importantly, did get the change accepted upstream: https://github.com/FreeRDP/FreeRDP/pull/1132/files

Note that this is a version for the 1.1 branch, whereas this patch is for 1.0. The same patch will be merged upstream soon as well, as a backport of the one mentioned above.

In summary, upstream is happy with the patch and I think it could be taken as a distro patch with the assurance that the delta will disappear with the upcoming 1.0.3 and 1.1 releases.

Reply
Revision history for this message
Rex Tsai (chihchun) wrote :

raring is using 1.0.1-2ubuntu1[1], but you are working on 1.0.1-1ubuntu7. I tested the patch, it clean applied to 1.0.1-2ubuntu1 as well.

Is this function blocking raring release?

[1] bzr+ssh://bazaar.launchpad.net/+branch/ubuntu/raring/freerdp

Reply
Revision history for this message
David Barth (dbarth) wrote :

Le 08/04/2013 10:56, Rex Tsai a écrit :
> raring is using 1.0.1-2ubuntu1[1], but you are working on 1.0.1-1ubuntu7. I tested the patch, it clean applied to 1.0.1-2ubuntu1 as well.
>
> Is this function blocking raring release?
 No fortunately it's not blocking, but nice to have if there's still
time, or as an update for the next package release.

David

Reply
Revision history for this message
David Barth (dbarth) wrote :

Le 08/04/2013 10:56, Rex Tsai a écrit :
> raring is using 1.0.1-2ubuntu1[1], but you are working on 1.0.1-1ubuntu7. I tested the patch, it clean applied to 1.0.1-2ubuntu1 as well.
>
> Is this function blocking raring release?
 With raring release almost done, when do you plan to integrate the patch
and prepare a new upload when the archive reopns?

David

Reply
Revision history for this message
David Barth (dbarth) wrote :

Le 08/04/2013 10:56, Rex Tsai a écrit :
> raring is using 1.0.1-2ubuntu1[1], but you are working on 1.0.1-1ubuntu7. I tested the patch, it clean applied to 1.0.1-2ubuntu1 as well.
>
> Is this function blocking raring release?
>
> [1] bzr+ssh://bazaar.launchpad.net/+branch/ubuntu/raring/freerdp
 Rex, can you consider this merge proposal again for Saucy? Thanks and
keep me posted.

David

Reply

Unmerged revisions

24. By David Barth

removing the changelog to help with raring integration

23. By David Barth

build for quantal

22. By David Barth

fixes for the add-wm-class

21. By David Barth

add-wm-class patch

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: