Unity Reddit Scope

Merge lp://staging/~davidc3/unity-scope-reddit/new-ssl-uri into lp://staging/unity-scope-reddit

new-ssl-uri
Merge into trunk

Proposed by David Callé on 2014-04-26

Status:

Merged

Approved by:

David Callé on 2014-05-02

Approved revision:

Merged at revision:

Proposed branch:

lp://staging/~davidc3/unity-scope-reddit/new-ssl-uri

Merge into:

lp://staging/unity-scope-reddit

Diff against target:

12 lines (+1/-1)

1 file modified

src/unity_reddit_daemon.py (+1/-1)

To merge this branch:

bzr merge lp://staging/~davidc3/unity-scope-reddit/new-ssl-uri

High

In Progress

Link a bug report

Reviewer	Review Type	Date Requested	Status
David Callé (community)			Approve on 2014-05-02
PS Jenkins bot (community)	continuous-integration		Approve on 2014-05-02
Simon Davy (community)			Approve on 2014-05-02
Chris Wayne (community)		2014-04-26	Approve on 2014-04-27
Review via email: mp+217342@code.staging.launchpad.net

Commit message

New API uri

Description of the change

New API uri

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-04-26:

FAILED: Continuous integration, rev:5
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~davidc3/unity-scope-reddit/new-ssl-uri/+merge/217342/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/unity-scope-reddit-ci/9/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-reddit-saucy-amd64-ci/9
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-reddit-saucy-armhf-ci/9
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-reddit-saucy-i386-ci/9

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-reddit-ci/9/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Chris Wayne (cwayne) wrote on 2014-04-27:

LGTM

review: Approve

Revision history for this message

David Callé (davidc3) wrote on 2014-04-27:

Thanks Chris, but before merging, I'm reaching to Reddit to get a definitive answer on their ssl API, this one appears to be redirecting to http anyway.

review: Needs Information

Revision history for this message

Olli Ries (ories) wrote on 2014-04-28:

what about the cert check, suggested by Marc? Ben's comments in the bug also seem to indicate that simply changing the URL won't fix it.

lp://staging/~davidc3/unity-scope-reddit/new-ssl-uri updated on 2014-05-02

6. By David Callé on 2014-05-02: Last week of research shows that no proper ssl reddit uri exists today for non-authenticated API calls. Switching to http for the server->reddit talk, user to server is -as always- https

Revision history for this message

Simon Davy (bloodearnest) on 2014-05-02:

review: Approve

Revision history for this message

Simon Davy (bloodearnest) wrote on 2014-05-02:

> what about the cert check, suggested by Marc? Ben's comments in the bug also
> seem to indicate that simply changing the URL won't fix it.

It will provide unauthenticated encryption, which is better than no encryption. Only prevents casual eavesdropping, not MITM, but that fix is bit more involved.

review: Approve

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-05-02:

PASSED: Continuous integration, rev:6
http://jenkins.qa.ubuntu.com/job/unity-scope-reddit-ci/10/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-reddit-saucy-amd64-ci/10
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-reddit-saucy-armhf-ci/10
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-reddit-saucy-i386-ci/10