Merge lp://staging/~davidc3/developer-ubuntu-com/webapp-generator-version-appname into lp://staging/developer-ubuntu-com
Proposed by
David Callé
| Status: | Merged |
|---|---|
| Approved by: | Michael Hall |
| Approved revision: | 113 |
| Merged at revision: | 96 |
| Proposed branch: | lp://staging/~davidc3/developer-ubuntu-com/webapp-generator-version-appname |
| Merge into: | lp://staging/developer-ubuntu-com |
| Diff against target: |
111 lines (+20/-17) 4 files modified
webapp_creator/resources/appname.desktop (+1/-1) webapp_creator/resources/manifest.json (+0/-1) webapp_creator/views.py (+10/-0) webapp_creator/woc.py (+9/-15) |
| To merge this branch: | bzr merge lp://staging/~davidc3/developer-ubuntu-com/webapp-generator-version-appname |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Hall (community) | Approve | ||
|
Review via email:
|
|||
Commit message
- Add version field
- Create appname using display name (cleaned and shortened if needed)
- Pre-fills name and email
Description of the change
- Add version field
- Create appname using display name (cleaned and shortened if needed)
- Pre-fills name and email
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM