Sales - Workflow and Organization

Merge lp://staging/~david-cormier-j/sale-wkfl/sale_landed_costs into lp://staging/~sale-core-editors/sale-wkfl/7.0

sale_landed_costs
Merge into 7.0

Proposed by David Cormier on 2014-02-10

Status:	Needs review
Proposed branch:	lp://staging/~david-cormier-j/sale-wkfl/sale_landed_costs
Merge into:	lp://staging/~sale-core-editors/sale-wkfl/7.0
Diff against target:	321 lines (+301/-0) 4 files modified sale_landed_costs/__init__.py (+26/-0) sale_landed_costs/__openerp__.py (+47/-0) sale_landed_costs/sale.py (+188/-0) sale_landed_costs/sale_view.xml (+40/-0)
To merge this branch:	bzr merge lp://staging/~david-cormier-j/sale-wkfl/sale_landed_costs
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Pedro Manuel Baeza			Needs Resubmitting on 2014-08-08
Joël Grand-Guillaume @ camptocamp	code review, no tests	2014-02-10	Needs Fixing on 2014-05-09
Review via email: mp+205650@code.staging.launchpad.net

Description of the change

Add a sale_landed_costs module

This module is an adaptation of the purchase_landed_costs (in c2c_rd_addons project) for sales

Revision history for this message

Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote on 2014-05-09:

Hi David,

Thanks for porting this module. A few remarks:

* Would you please consider using the BZR extractor (https://launchpad.net/bazaar-extractor) to put this module in that branch ? This will then keep the commite message insead of having just one commit that add the module. This seems fair on order to keep the author's work.

* Then, it deserve a bit of PEP8 formatting

Regards,

Joël

review: Needs Fixing (code review, no tests)

Revision history for this message

Pedro Manuel Baeza (pedro.baeza) wrote on 2014-08-08:

This project is now hosted on https://github.com/OCA/sale-workflow. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub