Merge lp://staging/~dave-cheney/juju-core/117-fix-juju-status-panic into lp://staging/~juju/juju-core/trunk
Proposed by
Dave Cheney
| Status: | Merged |
|---|---|
| Approved by: | William Reade |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 1178 |
| Proposed branch: | lp://staging/~dave-cheney/juju-core/117-fix-juju-status-panic |
| Merge into: | lp://staging/~juju/juju-core/trunk |
| Diff against target: |
77 lines (+41/-1) 2 files modified
cmd/juju/status.go (+2/-1) cmd/juju/status_test.go (+39/-0) |
| To merge this branch: | bzr merge lp://staging/~dave-cheney/juju-core/117-fix-juju-status-panic |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Juju Engineering | Pending | ||
|
Review via email:
|
|||
Description of the change
cmd/juju: don't panic if machine missing
* Properly handle the case where the provider provided instance id is not present.
* fix json and yaml formatting to hide a blank instance-id if the instance is missing.
* added tests for instance-id: "pending" and instance-state: "missing"
To post a comment you must log in.
Revision history for this message
| William Reade (fwereade) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM
https:/