Merge lp://staging/~dave-cheney/juju-core/071-cmd-jujud-stater-I into lp://staging/~juju/juju-core/trunk
Proposed by
Dave Cheney
| Status: | Work in progress |
|---|---|
| Proposed branch: | lp://staging/~dave-cheney/juju-core/071-cmd-jujud-stater-I |
| Merge into: | lp://staging/~juju/juju-core/trunk |
| Prerequisite: | lp://staging/~dave-cheney/juju-core/069-worker-stater-I |
| Diff against target: |
203 lines (+134/-13) (has conflicts) 5 files modified
cmd/jujud/main.go (+1/-0) cmd/jujud/stater.go (+29/-0) cmd/jujud/stater_test.go (+87/-0) environs/cloudinit/cloudinit.go (+16/-7) environs/cloudinit/cloudinit_test.go (+1/-6) Text conflict in environs/cloudinit/cloudinit.go |
| To merge this branch: | bzr merge lp://staging/~dave-cheney/juju-core/071-cmd-jujud-stater-I |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| The Go Language Gophers | Pending | ||
|
Review via email:
|
|||
Description of the change
cmd/jujud: introduce stater
Prereq: https:/
This proposal introduces a new jujud subcommand, stater. The stater command replaces the current shell scripting built into cloudinit.
In future proposals the stater will become a long lived command that is responsible for the configuration of the mongodb upstart job.
To post a comment you must log in.
Revision history for this message
| William Reade (fwereade) wrote | # |
Revision history for this message
| Roger Peppe (rogpeppe) wrote | # |
Unmerged revisions
- 852. By Dave Cheney
-
merge conflict, nothing to see here
- 851. By Dave Cheney
-
merge from trunk and respond to review feedback
- 850. By Dave Cheney
-
stater tests
- 849. By Dave Cheney
-
fix tests
- 848. By Dave Cheney
-
merge from prereq
- 847. By Dave Cheney
-
remove double dd
- 846. By Dave Cheney
-
merge from prereq
- 845. By Dave Cheney
-
wip
- 844. By Dave Cheney
-
wip
- 843. By Dave Cheney
-
wip
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
https:/
File cmd/jujud/main.go (right):
https:/
cmd/jujud/
Either this needs a *stater.Config (-1), or the command itself needs to
set one up itself (+1); ISTM that it doesn't, and the tests poke all
that info in directly. Did I miss something?
https:/
File cmd/jujud/stater.go (right):
https:/
cmd/jujud/
Why embed a (nil) pointer when you could just embed directly...
https:/
cmd/jujud/
...initialize the fields here...
https:/
cmd/jujud/
...and pass &s.Config here?
https:/
File cmd/jujud/
https:/
cmd/jujud/
There are a lot of these scattered through the codebase, but maybe it's
not worth factoring them into one place. Thoughts?
https:/
File environs/
https:/
environs/
err != nil {
I don't think this change is justified yet -- we don't pass any of the
necessary information in. (Does this actually run correctly? I don't see
how it can...)
https:/